Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for division by zero in RecoBTag/PerformanceDB #5415

Conversation

ferencek
Copy link
Contributor

Added check that prevents division by zero

@StoyanStoynev
Copy link
Contributor

@cmsbuild please run tests
the PR is super trivial but still...

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_2_X.

Fix for division by zero in RecoBTag/PerformanceDB

It involves the following packages:

RecoBTag/PerformanceDB

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@StoyanStoynev
Copy link
Contributor

@cmsbuild please run tests

@davidlt
Copy link
Contributor

davidlt commented Sep 18, 2014

@StoyanStoynev it's sitting in a queue waiting for a free machine to test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
For 42ef699 .
Trivial bug fix (a "harmless" division by zero prompting warnings was fixed).
Jenkins fine, no diffs.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). @nclopezo can you please take care of it?

davidlange6 added a commit that referenced this pull request Sep 23, 2014
…PerformanceDB_from-CMSSW_7_2_0_pre6

Fix for division by zero in RecoBTag/PerformanceDB
@davidlange6 davidlange6 merged commit 22e7689 into cms-sw:CMSSW_7_2_X Sep 23, 2014
@ferencek ferencek deleted the FixDivisionByZeroInRecoBTagPerformanceDB_from-CMSSW_7_2_0_pre6 branch September 23, 2014 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants