fix getByLabel

[quertenmont]

No description provided.

[cmsbuild]

A new Pull Request was created by @quertenmont (Loic Quertenmont) for CMSSW_7_3_X.

fix getByLabel

It involves the following packages:

SUSYBSMAnalysis/HSCP

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
Tested at: ad897cb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5428/16/summary.html

[vadler]

You switch from config parameters to constant InputTags. Is that intentionally?
If not, it should rather look like

m_dtSegmentToken = consumes< DTRecSegment4DCollection >(iConfig.getParameter<edm::InputTag>("DTSegments") );

[vadler]

Of course, any (future) comment also holds for #5427 .

[quertenmont]

Hi Volker,

Thanks for looking into it,
this is all private code that is never run in production,
so I don't believe that the scrutiny needs to be so high.
But I'll make the changes you suggest at some point, but for this PR, I think what is there is fine.

Loic,

[vadler]

@quertenmont : I guess, you refer to #5428 (comment) here. It's ok, since this clean-up is not the main subject of this PR.
This lets #5428 (comment) untouched, which points to a real bug, if my assumption is correct.

[quertenmont]

As I said, none of this really matter since it's private code that is not run in production
But since I can make you happy so easilly... I updated the request...

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

[cmsbuild]

+1
Tested at: 1ad3f08
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5428/26/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5428/26/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5428/16/summary.html