Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Data sync #5432

Merged
merged 1 commit into from Sep 22, 2014
Merged

External Data sync #5432

merged 1 commit into from Sep 22, 2014

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Sep 19, 2014

  • Bring in all xml data files in a release.
  • Geometry external data can be deleted from now on.

@ianna
Copy link
Contributor Author

ianna commented Sep 19, 2014

@smuzaffar - Please, remove Geometry external data after integrating this PR. Thanks. Yana

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_7_3_X.

External Data sync

It involves the following packages:

Geometry/EcalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor Author

ianna commented Sep 19, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

smuzaffar added a commit that referenced this pull request Sep 22, 2014
@smuzaffar smuzaffar merged commit 322c1b7 into cms-sw:CMSSW_7_3_X Sep 22, 2014
@smuzaffar
Copy link
Contributor

cms-sw/cmsdist#1045 drops all the data-Geometry- external dependencies

@ianna ianna deleted the ecal-data-external branch October 26, 2015 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants