Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated minimal pythia 8 interface changes for 8.200pre1 #5436

Merged
4 commits merged into from Sep 22, 2014

Conversation

bendavid
Copy link
Contributor

Must be taken together with
cms-sw/cmsdist#1028

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_7_3_X.

Updated minimal pythia 8 interface changes for 8.200pre1

It involves the following packages:

FastSimulation/ParticleDecay
GeneratorInterface/PartonShowerVeto
GeneratorInterface/Pythia8Interface

@vciulli, @civanch, @nclopezo, @lveldere, @mdhildreth, @cmsbuild, @thuer, @bendavid can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@bendavid
Copy link
Contributor Author

+1

@ghost
Copy link

ghost commented Sep 19, 2014

+1
Tested against cms-sw/cmsdist#1028.
Ran workflows: 1306.0,101.0,1003.0,50101.0,9.0,25202.0
No failure encountered.

@cmsbuild
Copy link
Contributor

-1
Tested at: 6710873
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-09-19-0200/src/GeneratorInterface/PartonShowerVeto/src/JetMatchingMadgraph.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-09-19-0200/src/GeneratorInterface/PartonShowerVeto/src/JetMatchingPy8Internal.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-09-19-0200/src/GeneratorInterface/PartonShowerVeto/src/SetNumberOfPartonsDynamically.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-09-19-0200/src/GeneratorInterface/PartonShowerVeto/src/alpg_match.F 
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-09-19-0200/src/GeneratorInterface/PartonShowerVeto/src/SetNumberOfPartonsDynamically.cc:1:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-09-19-0200/src/GeneratorInterface/PartonShowerVeto/interface/SetNumberOfPartonsDynamically.h:14:35: fatal error: Pythia8Plugins/HepMC2.h: No such file or directory
 #include "Pythia8Plugins/HepMC2.h"
                                   ^
compilation terminated.
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-09-19-0200/src/GeneratorInterface/PartonShowerVeto/src/SetNumberOfPartonsDynamically.cc:1:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_3_X-slc6_amd64_gcc481/CMSSW_7_3_X_2014-09-19-0200/src/GeneratorInterface/PartonShowerVeto/interface/SetNumberOfPartonsDynamically.h:14:35: fatal error: Pythia8Plugins/HepMC2.h: No such file or directory


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5436/30/summary.html

@bendavid
Copy link
Contributor Author

(Automated test failures can of course be ignored, given that the cmsdist pull has to go in parallel)

@lveldere
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

@ghost
Copy link

ghost commented Sep 22, 2014

+1
I already wrote that the tests are fine, re posting just for the records.

ghost pushed a commit that referenced this pull request Sep 22, 2014
Updated minimal pythia 8 interface changes for 8.200pre1
@ghost ghost merged commit 3b1c7de into cms-sw:CMSSW_7_3_X Sep 22, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants