Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM/SiStripMonitorDigi: remove unsued subdetswitchtotdigiproflson #5455

Merged
merged 1 commit into from
Sep 23, 2014

Commits on Sep 21, 2014

  1. DQM/SiStripMonitorDigi: remove unsued subdetswitchtotdigiproflson

    According to UBSan
    
        DQM/SiStripMonitorDigi/src/SiStripMonitorDigi.cc:275:3
    
    triggers undefined behavior 193 times on full matrix run.
    
    Example workflows:
    - 4.68 / step2
    - 1309.0 / step3
    - 140.52 / step2
    
    This happens before the first even is executed.
    
    After looking into the code the problem is triggered by uninitialized
    (?) bool member variable subdetswitchtotdigiproflson used in if
    statement. The if statement had an empty body! I cleaned up the source
    code by removing all references of subdetswitchtotdigiproflson.
    According GIT it's not used anywhere in CMSSW (apart that empty if
    statement).
    
    Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
    David Abdurachmanov authored and David Abdurachmanov committed Sep 21, 2014
    Configuration menu
    Copy the full SHA
    537367e View commit details
    Browse the repository at this point in the history