Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same as #5525 (#4914 #4833 #4862 #5037 #5230 plus #5425 and other fixes) MiniAOD related #5526

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Sep 24, 2014

This PR should include all fixes from
https://twiki.cern.ch/twiki/bin/view/CMS/MiniAODCSA14FollowUp
plus Sal PR (#5425) and other fixes for AK5->AK4

same as #5525 but against 72X

rappoccio and others added 29 commits September 18, 2014 08:55
…ents (in particular, the process names for l1 information were wrong, so the objects were not kept)

Conflicts:
	PhysicsTools/PatAlgos/python/slimming/slimming_cff.py
…etter implementation of the whole pat::MET corrections (independent from the uncertainties, and more similar to the one of pat::Jet) would be better, but would be a much more intrusive change, while this one is minimal and preserves compatibility
…7_5230_From720pre6Plus5425

Mini ao dports of 4914 4833 4862 5037 5230 from720pre6 plus5425
@cmsbuild cmsbuild added this to the Next CMSSW_7_2_X milestone Sep 24, 2014
@cmsbuild
Copy link
Contributor

Pull request #5526 was updated. @nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler can you please check and sign again.

@vadler
Copy link

vadler commented Sep 26, 2014

+1
We are there (at least from my point of view). Thanx a lot!

@vadler
Copy link

vadler commented Sep 26, 2014

@cmsbuild : Please test as soon as CMSSW_7_2_X_2014-09-25-0200 arrives.

davidlange6 added a commit that referenced this pull request Sep 26, 2014
…37_5230_From720pre6Plus5425

Same as #5525 (#4914 #4833 #4862 #5037 #5230 plus #5425 and other fixes) MiniAOD related
@davidlange6 davidlange6 merged commit 9c8306e into cms-sw:CMSSW_7_2_X Sep 26, 2014
@cmsbuild
Copy link
Contributor

-1

Tested at: 0246744
I ran the usual tests and I found errors in the following unit tests:

---> test runtestUtilAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5526/1/summary.html

@rappoccio
Copy link
Contributor

Merged this into #5350 for the record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants