Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed obsolete calls to flag isData #5538

Merged
merged 2 commits into from Sep 25, 2014

Conversation

sordini
Copy link
Contributor

@sordini sordini commented Sep 24, 2014

Just small changes to a single file to remove a flag that was not used (and not initialised) anymore. I started from CMSSW_7_3_X_2014-09-23-13400.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sordini for CMSSW_7_3_X.

removed obsolete calls to flag isData

It involves the following packages:

DQMOffline/JetMET

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks.
@nhanvtran, @TaiSakuma, @schoef, @mmarionncern, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Sep 24, 2014

thanks @sordini for this.
I guess that we can remove the same at:
https://github.com/JetMETdqmval/cmssw/blob/develop_DQM_73x_v0/DQMOffline/JetMET/src/DataCertificationJetMET.cc#L410

could you please do it?
thanks,
F.

@cmsbuild
Copy link
Contributor

Pull request #5538 was updated. @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please check and sign again.

@sordini
Copy link
Contributor Author

sordini commented Sep 24, 2014

Sorry about that, it's done and commited to the same branch.
Thanks

@deguio
Copy link
Contributor

deguio commented Sep 24, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Sep 25, 2014
removed obsolete calls to flag isData
@davidlange6 davidlange6 merged commit 754ae23 into cms-sw:CMSSW_7_3_X Sep 25, 2014
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants