New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default python values for new parameters introduced with PR 5255 #5548
Default python values for new parameters introduced with PR 5255 #5548
Conversation
@slava77 @StoyanStoynev Is there automatic forward port to 73x, or should I make new PR ? |
A new Pull Request was created by @jpavel (Pavel Jez) for CMSSW_7_2_X. Default python values for new parameters introduced with PR 5255 It involves the following packages: RecoTauTag/RecoTau @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
No auto forward ports, Giulio made few "by hand" and I understood these were exceptions not to happen again (though it did happen at least once again). Thus you should make a new one for 73X. |
auto-forward port means the porting happens without asking.. There is still the forward port that creates a pull request… but indeed, make a PR for 73x as a general rule On Sep 25, 2014, at 8:36 AM, StoyanStoynev notifications@github.com
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. @nclopezo can you please take care of it? |
Default python values for new parameters introduced with PR 5255
A bugfix: #5255 introduced new parameters for the discriminationByIsolation EDProducer, but did not define their default value in python. This fix is important for HLT.
@mbluj