Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default python values for new parameters introduced with PR 5255 #5548

Merged

Conversation

jpavel
Copy link
Contributor

@jpavel jpavel commented Sep 24, 2014

A bugfix: #5255 introduced new parameters for the discriminationByIsolation EDProducer, but did not define their default value in python. This fix is important for HLT.

@mbluj

@jpavel
Copy link
Contributor Author

jpavel commented Sep 24, 2014

@slava77 @StoyanStoynev Is there automatic forward port to 73x, or should I make new PR ?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jpavel (Pavel Jez) for CMSSW_7_2_X.

Default python values for new parameters introduced with PR 5255

It involves the following packages:

RecoTauTag/RecoTau

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@StoyanStoynev
Copy link
Contributor

No auto forward ports, Giulio made few "by hand" and I understood these were exceptions not to happen again (though it did happen at least once again). Thus you should make a new one for 73X.

@davidlange6
Copy link
Contributor

auto-forward port means the porting happens without asking.. There is still the forward port that creates a pull request… but indeed, make a PR for 73x as a general rule

On Sep 25, 2014, at 8:36 AM, StoyanStoynev notifications@github.com
wrote:

No auto forward ports, Giulio made few "by hand" and I understood these were exceptions not to happen again (though it did happen at least once again). Thus you should make a new one for 73X.


Reply to this email directly or view it on GitHub.

@StoyanStoynev
Copy link
Contributor

+1
Tested e426c96 on top of CMSSW_7_2_X_2014-09-22-0200. No effect on standard RECO (short matrix and ttbar samples with PU - upto 200 events) and none expected (affecting only a customization running).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. @nclopezo can you please take care of it?

davidlange6 added a commit that referenced this pull request Sep 25, 2014
Default python values for new parameters introduced with PR 5255
@davidlange6 davidlange6 merged commit cc1ff02 into cms-sw:CMSSW_7_2_X Sep 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants