Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ProcessConfigurationRegistry #560

Merged
merged 1 commit into from Aug 20, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Aug 16, 2013

This pull request removes the process configuration registry, which is an impediment to thread safety, from the framework.
The changes outside the framework are the minimal adaption to this change.

@ghost ghost assigned nclopezo Aug 18, 2013
@ktf
Copy link
Contributor

ktf commented Aug 18, 2013

@rovere @deguio @vciulli can you sign off?
@nclopezo can you test?

@cmsbuild
Copy link
Contributor

The following categories have been signed by ciulli (a.k.a. @vciulli on GitHub): Generators

@cms-git-generators

@nclopezo
Copy link
Contributor

Hi,

I took these changes on top of CMSSW_7_0_X_2013-08-19-0200, I ran the unit tests and RelVals, all tests passed.

You can see the logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/145/console

@cmsbuild
Copy link
Contributor

The following categories have been signed by chrjones (a.k.a. @Dr15Jones on GitHub): Core

@cms-git-visualization, @cms-git-core, @cms-git-geometry

@ktf
Copy link
Contributor

ktf commented Aug 19, 2013

@rovere @deguio you are the only one left. can you look into this, please?

@wmtan
Copy link
Contributor Author

wmtan commented Aug 19, 2013

I would request that the DQM signature be bypassed if it is not signed in a timely manner, say by tomorrow (Tuesday) morning. The DQM code involved was written by Chris Jones, not DQM people, and the change is trivial, and is the minimum necessary for compilation.
Also, this is in the critical path for the multithreaded framework, and another pull request that should be ready to be done today is dependent on this request. Of course, the new request could go in before this one is merged, but then the topic collector would indicate that the new request needs all the same signatures from this request, which is not the case.

ktf added a commit that referenced this pull request Aug 20, 2013
@ktf ktf merged commit a27555d into cms-sw:CMSSW_7_0_X Aug 20, 2013
@ktf
Copy link
Contributor

ktf commented Aug 20, 2013

Billl, thanks for the explanations. I've bypassed the signature.

@wmtan wmtan deleted the RemoveProcessConfigurationRegistry branch August 20, 2013 13:58
@deguio
Copy link
Contributor

deguio commented Aug 22, 2013

just for info: the changes have been tested and everything went fine.
sorry guys for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants