Delete ME after writing

[deguio]

@Dr15Jones
this should address the comment you made to #5650

comments are welcome.. :)

ciao,
F.

[cmsbuild]

A new Pull Request was created by @deguio for CMSSW_7_1_X.

Delete ME after writing

It involves the following packages:

DQMServices/Components
DQMServices/Core

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

The call to erase invalidated i_lumi so you can't advance it. I think what you need to do is

auto temp = i_lumi++;
if( temp->getFullname() ... ) {
   data_.erase(temp);
}

[deguio]

hello @Dr15Jones
thanks for the comments. about the i_lumi iterator you are absolutely right. I have just pushed the change you propose.

For what concerns the markToDelete method, it is triggered only by the DQMFileSaver, which is a global module, at the globalEndLumi on old MEs (belonging lumis older than the current one).
The operation should never happen concurrently. I have discussed this with Marco and, If you agree, we would leave it as it is.
thanks,
F.

[cmsbuild]

Pull request #5682 was updated. @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please check and sign again.

[deguio]

now the two methods markedToDelete and markToDelete are private in MonitorElement

[cmsbuild]

Pull request #5682 was updated. @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please check and sign again.

[cmsbuild]

+1
Tested at: db44fc8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5682/1974/summary.html

[deguio]

sure, I will add a comment. at the moment this is not the case.
thanks for scrutinising this,
F.

[cmsbuild]

Pull request #5682 was updated. @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please check and sign again.

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @Degano can you please take care of it?