New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang fixes related to Boost Serialization #5692
Conversation
According to signature at base class the first argument to function is passed not as a value, but as a reference. Change it accordingly to match the signature in base class. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
According to the header, ChamberLocationSpec is not a class, but a struct. Change forward declarations accordingly. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
A new Pull Request was created by @davidlt for CMSSW_7_3_X. Clang fixes related to Boost Serialization It involves the following packages: CalibFormats/SiPixelObjects @apfeiffer1, @diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @ggovi can you please review it and eventually sign? Thanks. |
@@ -174,7 +174,7 @@ namespace pos{ | |||
|
|||
virtual void writeASCII(std::string dir="") const; | |||
void writeXML( pos::PixelConfigKey key, int version, std::string path) const {;} | |||
virtual void writeXMLHeader( pos::PixelConfigKey key, | |||
virtual void writeXMLHeader( pos::PixelConfigKey &key, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please make this a "const pos::PixelConfigKey &key" to avoid accidental modification of something which was previously copied ? Even if "key" is actually not used in the method. :)
[also in the corresponding .cc file, of course :) ]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought something similar. But when again this would be hiding overloaded function, I think. If that should be done on a base class are lot more classes would need to be modified, but that would fix quite a number of Clang errors/warnings. There are a lot more files having exact same issue, mis-matching signature and then hiding overloaded method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
In CalibFormats/SiPixelObjects/interface/PixelCalibConfiguration.h:
@@ -174,7 +174,7 @@ namespace pos{
virtual void writeASCII(std::string dir="") const; void writeXML( pos::PixelConfigKey key, int version, std::string path) const {;}
- virtual void writeXMLHeader( pos::PixelConfigKey key,
- virtual void writeXMLHeader( pos::PixelConfigKey &key,
I thought something similar. But when again this would be hiding
overloaded function, I think. If that should be done on a base class are
lot more classes would need to be modified, but that would fix quite a
number of Clang errors/warnings. There are a lot more files having exact
same issue, mis-matching signature and then hiding overloaded method.ah, sorry, did not check for that. agreed then - until we have the time to
attack the base-class and all it's usages. :(
Thanks,
cheers, andreas
@apfeiffer1 I think, your +1 is not counted it as it's in "inline" comments. |
+1 On Sun, Oct 5, 2014 at 10:41 PM, davidlt notifications@github.com wrote:
Thanks, |
+1 |
Clang fixes related to Boost Serialization
The following fixes a few errors reported by Clang and seen by Boost Serialization script.