Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pdigitizer merging curr upg 3 #5717

Merged
merged 4 commits into from Oct 13, 2014

Conversation

ahazi137
Copy link
Contributor

@ahazi137 ahazi137 commented Oct 7, 2014

Porting the pixel-aging feature used in 62XSLHC branch by pixel digitizer (for upgrade studies) to 73X.
Deleting the pseudoRadDamage variables since they are not used.
Some indent corrections in drift () function ( SimTracker/SiPixelDigitizer/plugins/SiPixelDigitizerAlgorithm.cc ).

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2014

A new Pull Request was created by @ahazi137 for CMSSW_7_3_X.

Pdigitizer merging curr upg 3

It involves the following packages:

SimGeneral/MixingModule
SimTracker/SiPixelDigitizer

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@wmtan, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @dkotlins, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2014

@civanch
Copy link
Contributor

civanch commented Oct 10, 2014

+1

1 similar comment
@civanch
Copy link
Contributor

civanch commented Oct 12, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Oct 13, 2014
@nclopezo nclopezo merged commit 6ebaf70 into cms-sw:CMSSW_7_3_X Oct 13, 2014
@ahazi137 ahazi137 deleted the pdigitizer-merging-curr-upg-3 branch October 15, 2014 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants