Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgarde Tracker pahse1&2 Development configuration #5720

Merged
merged 14 commits into from Oct 14, 2014

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Oct 7, 2014

Configuring dev scenarios for tracker phase1 and phase2 :
xmls/ config are for the moment clone in dev folders and dev extensions to allow further developments without disturbing anybody (in particular TP MC production) - To test these 2 new scenarios I used runTheMatrix.py --what upgrade -l 10600,10800 (or in general 106xx for phase1 and 108xxx for phase2 - those are replacing the old Be5Dfast and 2017fast never used)
None of the usual numbering in runthematrix is touched (which means that this should be transparent for any shashlik , hgcal etc .. scenarios ) - I took also this opportunity to remove LongBarrel old config files (deprecated for 1.5 years)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2014

A new Pull Request was created by @boudoul (boudoul) for CMSSW_6_2_X_SLHC.

Upgarde Tracker pahse1&2 Development configuration

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Geometry/CMSCommonData
Geometry/TrackerCommonData
Geometry/TrackerRecoData
Geometry/TrackerSimData
SLHCUpgradeSimulations/Configuration

@civanch, @Dr15Jones, @vlimant, @ianna, @mdhildreth, @cmsbuild, @franzoni, @nclopezo, @ktf, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@boudoul
Copy link
Contributor Author

boudoul commented Oct 9, 2014

I took the liberty to update this PR with the new digitizer (in the dev customisations, so no worry for the official WF)
@suchandradutta , @lowette :
the workflow with the new digitizer can be run using the following command
runTheMatrix.py --what upgrade -l 10800
(or any number like 108XX)
(also adding @venturia FYI)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2014

Pull request #5720 was updated. @civanch, @Dr15Jones, @vlimant, @ianna, @mdhildreth, @cmsbuild, @franzoni, @nclopezo, @ktf, @davidlange6 can you please check and sign again.

from SLHCUpgradeSimulations.Configuration.phase1TkCustomsPixel10D import customise as customisePhase1TkPixel10D
from SLHCUpgradeSimulations.Configuration.combinedCustoms_TTI import customise as customiseTTI
from SLHCUpgradeSimulations.Configuration.combinedCustoms_TTI import l1EventContent_TTI as customise_ev_l1tracker
from SLHCUpgradeSimulations.Configuration.combinedCustoms_TTI import l1EventContent_TTI_forHLT

from SLHCUpgradeSimulations.Configuration.customise_mixing import customise_NoCrossing
from SLHCUpgradeSimulations.Configuration.phase1TkCustoms import customise as customisePhase1Tk
from SLHCUpgradeSimulations.Configuration.phase1TkCustomsdev import customise as customisePhase1Tkdev

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boudoul
This line should be in addition instead of replacing, otherwise the non-dev cust_2017 and cust_2019 don't work. I have it fixed in a branch which I'm currently testing and will merge soon - no need for you to do anything. Sorry for the delay.

@mark-grimes
Copy link

Superseded by #5810. This should close automatically when that is merged.

@cmsbuild cmsbuild merged commit 86db4b4 into cms-sw:CMSSW_6_2_X_SLHC Oct 14, 2014
cmsbuild added a commit that referenced this pull request Oct 14, 2014
@boudoul
Copy link
Contributor Author

boudoul commented Oct 15, 2014

Thanks @mark-grimes ! Sorry I didn't check my git folder for a few days and I read with a bit of delay your comments/ work - Perfect- Thanks for having noticed the pb with 2017 and 2019!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants