Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTI 62 x Version of the code used for the TP version circulated in August #5722

Merged

Conversation

EmanuelPerez
Copy link

  • contains the L1Tracking code (tracklet approach).
  • contains the Track-Trigger object algorithms (the various L1TkXXXProducers in SLHCUpgradeSimulations/L1TrackTrigger/plugins)
  • L1Jet algorithm: new code from Nick Wardle, Jad Marrouche et al, which delivers L1Jets that are reasonable even at PU=140 (SLHCUpgradeSimulations/L1CaloTrigger). I think there were changes in SimDataFormats/SLHC as well, for the L1CaloTower.h et al files
  • also contains the (new) code that builds simple L1EG objects based on crystal-level information, from Nick Smith and Sasha Savin (in SLHCUpgradeSimulations/L1CaloTrigger/plugins, L1ExtraCrystalPosition.cc and L1EGammaCrystalsProducer.cc. New class L1EGCrystalCluster.h in SimDataFormats/SLHC)

EmanuelPerez and others added 30 commits May 14, 2014 12:04
Merge branch 'CrystalLevel' into tempMerge
…t_L1TkCalo_cfg.py to also run with the L1Jets
… only for CSC. For other detectors, it's only marginally more useful than L1MuonParticle. Needs work from other areas
…ality of L1MuonParticleExtended is still not used (current impl would've worked with just the L1MuonParticle with a few extra hacks)
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2014

A new Pull Request was created by @EmanuelPerez for CMSSW_6_2_X_SLHC.

TTI 62 x Version of the code used for the TP version circulated in August

It involves the following packages:

DataFormats/L1DTPlusTrackTrigger
DataFormats/L1TrackTrigger
DataFormats/L1Trigger
Geometry/TrackerGeometryBuilder
L1Trigger/DTPlusTrackTrigger
L1Trigger/DTTrigger
L1Trigger/L1ExtraFromDigis
RecoHI/HiJetAlgos
SLHCUpgradeSimulations/L1CaloTrigger
SLHCUpgradeSimulations/L1TrackTrigger
SimDataFormats/SLHC

The following packages do not have a category, yet:

DataFormats/L1DTPlusTrackTrigger
L1Trigger/DTPlusTrackTrigger
SLHCUpgradeSimulations/L1TrackTrigger
SimDataFormats/SLHC

@civanch, @nclopezo, @ianna, @mdhildreth, @ktf, @cmsbuild, @Dr15Jones, @StoyanStoynev, @slava77, @mulhearn can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @jazzitup, @VinInn, @yslai, @yenjie, @kurtejung, @mandrenguyen, @richard-cms, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Oct 7, 2014

please remove the following files

 A L1Trigger/DTPlusTrackTrigger/test/.__afs3C91 (1593)
A L1Trigger/DTPlusTrackTrigger/test/.__afs4B1 (906)
A L1Trigger/DTPlusTrackTrigger/test/.__afs72E4 (1710)
A L1Trigger/DTPlusTrackTrigger/test/.__afs7891 (1661)
A L1Trigger/DTPlusTrackTrigger/test/.__afsA51D (1638)
A L1Trigger/DTPlusTrackTrigger/test/.__afsBE86 (1130)

@mark-grimes
Copy link

Also getting a compile error from DataFormats/L1Trigger/src/classes_def.xml

error: class 'l1extra::L1MuonParticleExtended::StationData' has a different checksum for ClassVersion 10. Increment ClassVersion to 11 and assign it to checksum 234715042

I've also noticed some other issues with that file. I'll put in a pull request to @EmanuelPerez's branch later tonight.

@EmanuelPerez
Copy link
Author

sorry for that Mark.

I do not get this compilation error, though.

Thanks and cheers,
E.

On Oct 7, 2014, at 5:58 PM, Mark Grimes wrote:

Also getting a compile error from DataFormats/L1Trigger/src/classes_def.xml

error: class 'l1extra::L1MuonParticleExtended::StationData' has a different checksum for ClassVersion 10. Increment ClassVersion to 11 and assign it to checksum 234715042
I've also noticed some other issues with that file. I'll put in a pull request to @EmanuelPerez's branch later tonight.


Reply to this email directly or view it on GitHub.

@mark-grimes
Copy link

Superseded by #5920. This should close automatically when that is merged.

@cmsbuild cmsbuild merged commit ad07346 into cms-sw:CMSSW_6_2_X_SLHC Oct 22, 2014
cmsbuild added a commit that referenced this pull request Oct 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants