Forward port of CMSSW_7_2_X into CMSSW_7_3_X #5738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se in custom function
The if statement would never be true. With this fix the functionality is preserved with some more information in case of error.
Fix sim g4 core generators
The eg candidates were intially part of the PU calculation to be used for a region-calibration scheme which was abandoned. Clean up the PU code to no longer need egcands and to simplify the logic.
…-report-gen Guard against blank lines in db.txt which cause tlf2esd.txt report to not be generated.
…ng to fix various runtests by setting the GT to run2_mc
…ies runtest. Also fixing a couple of stray AK5s from python files more than one layer deep in the package
…T uncertainty test
cmsbuild
added
alca-pending
analysis-pending
comparison-available
dqm-pending
fastsim-pending
generators-pending
hlt-pending
l1-pending
pending-signatures
reconstruction-pending
tests-approved
visualization-pending
and removed
alca-pending
analysis-pending
comparison-pending
dqm-pending
fastsim-pending
generators-pending
hlt-pending
l1-pending
pending-signatures
reconstruction-pending
tests-approved
visualization-pending
labels
davidlange6
added a commit
that referenced
this pull request
Oct 9, 2014
Forward port of CMSSW_7_2_X into CMSSW_7_3_X
| edm::LogError("HepMCValidationHelper") << "Tau with no daughters. This is a bug. Fix it"; | ||
| continue; | ||
| abort(); |
There was a problem hiding this comment.
This abort is annoying:
- 72X doesn't have it https://github.com/cms-sw/cmssw/blob/CMSSW_7_2_X/Validation/EventGenerator/src/HepMCValidationHelper.cc
- 71X doesn't have it https://github.com/cms-sw/cmssw/blob/CMSSW_7_1_X/Validation/EventGenerator/src/HepMCValidationHelper.cc#L188
Why does the forward port have it?
Just as a minor advice, DON'T call abort or exit, throw an exception so that the job can terminate gracefully.
There was a problem hiding this comment.
Because the abort() in 73X was more recently merged than the continue in 72X.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @civanch #5643 is ignored in this forward port.