New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing exceptions to LogErrors where appropriate #5804
Changing exceptions to LogErrors where appropriate #5804
Conversation
A new Pull Request was created by @rappoccio for CMSSW_7_3_X. Changing exceptions to LogErrors where appropriate It involves the following packages: CondFormats/JetMETObjects @apfeiffer1, @nclopezo, @monttj, @cmsbuild, @ggovi, @vadler can you please review it and eventually sign? Thanks. |
Sal -do we need a 70x fix for this? On Oct 13, 2014, at 9:47 PM, rappoccio notifications@github.com
|
// lep2 = pTrel2 + pLrel2 | ||
pTrel2 = lep2-pLrel2; | ||
} | ||
edm::LogError("JetCorrectionUncertainty")<<" not positive lepton-jet momentum: "<<lj2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this logError not be inside an "else" or something ?
+1 |
CondFormats/JetMETObjects -- Changing exceptions to LogErrors where appropriate
Forward-port of #5803