Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing exceptions to LogErrors where appropriate #5804

Merged
merged 2 commits into from Oct 15, 2014

Conversation

rappoccio
Copy link
Contributor

Forward-port of #5803

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rappoccio for CMSSW_7_3_X.

Changing exceptions to LogErrors where appropriate

It involves the following packages:

CondFormats/JetMETObjects

@apfeiffer1, @nclopezo, @monttj, @cmsbuild, @ggovi, @vadler can you please review it and eventually sign? Thanks.
@nhanvtran, @TaiSakuma, @mmarionncern, @schoef this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

Sal -do we need a 70x fix for this?

On Oct 13, 2014, at 9:47 PM, rappoccio notifications@github.com
wrote:

Forward-port of #5803

You can merge this Pull Request by running

git pull https://github.com/rappoccio/cmssw rappoccio_73x_jec_exception
Or view, comment on, or merge it at:

#5804

Commit Summary

• Changing exceptions to LogErrors where appropriate
File Changes

• M CondFormats/JetMETObjects/interface/JetCorrectorParameters.h (1)
• M CondFormats/JetMETObjects/interface/Utilities.h (4)
• M CondFormats/JetMETObjects/src/JetCorrectionUncertainty.cc (101)
• M CondFormats/JetMETObjects/src/SimpleJetCorrectionUncertainty.cc (22)
Patch Links:

https://github.com/cms-sw/cmssw/pull/5804.patch
https://github.com/cms-sw/cmssw/pull/5804.diff

Reply to this email directly or view it on GitHub.

// lep2 = pTrel2 + pLrel2
pTrel2 = lep2-pLrel2;
}
edm::LogError("JetCorrectionUncertainty")<<" not positive lepton-jet momentum: "<<lj2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this logError not be inside an "else" or something ?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@vadler
Copy link

vadler commented Oct 15, 2014

+1
Based on #5803 (comment) .

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Oct 15, 2014
CondFormats/JetMETObjects -- Changing exceptions to LogErrors where appropriate
@nclopezo nclopezo merged commit 75cdd4c into cms-sw:CMSSW_7_3_X Oct 15, 2014
@rappoccio rappoccio deleted the rappoccio_73x_jec_exception branch November 24, 2014 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants