Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More forward porting from CMSSW_7_2_X #5809

Merged
merged 30 commits into from Oct 14, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Oct 14, 2014

While forward porting the following bits conflicted:

  • RecoTracker/DeDx/plugins/HLTDeDxFilter.cc
<<<<<<< HEAD 
       //calculate relative trk isolation only if parameter maxRelTrkIsoDeltaRp3 is less than 0 
       if(maxRelTrkIsoDeltaRp3_ >= 0){ 
         auto ptCone = trackCollection[i].pt(); 
         for(unsigned int j=0; j<trackCollection.size(); j++){ 
         reco::TrackRef track2  = reco::TrackRef( trackCollectionHandle, j ); 
======= 
       //calculate relative trk isolation only if parameter maxRelTrkIsoDeltaRp3 is greater than 0 
       if(maxRelTrkIsoDeltaRp3_ >= 0){ 
         auto ptCone = trackCollection[i].pt(); 
         for(unsigned int j=0; j<trackCollection.size(); j++){ 
>>>>>>> cms-sw/CMSSW_7_2_X 

In this case I picked up the 72X version since the commend is actually correct there.

  • Configuration/PyReleaseValidation/python/relval_steps.py:
++<<<<<<< HEAD
 +steps['RECOHI']=merge([hiDefaults,{'-s':'RAW2DIGI,L1Reco,RECO,VALIDATION,DQM'},step3Defaults])
 +
++=======
+ steps['RECOHI']=merge([hiDefaults,{'-s':'RAW2DIGI,L1Reco,RECO,VALIDATION,DQM'},step3Up2015Defaults])
+ #wmsplit['RECOHI']=5
++>>>>>>> cms-sw/CMSSW_7_2_X

I picked up again the CMSSW_7_2_X version since that's what I was asked to do also in the past.

Adrien and others added 30 commits October 7, 2014 14:35
fix the electronIDs for the miniAOD step
Changes for new L1 and residual HLT fixes
Fix for RelVal definition for HIon case
…rkFilterIn72X

backport PR#5767 in CMSSW_7_2_X (Addition of a parameter in HLTMuonTrkFilter to cut on absEta)
Added configurable parameters: nValidHits, nMissIn, nMissMid, maxRelTrkIsoDeltaRp3, relTrkIsoDeltaRSize
Conflicts:
	Configuration/PyReleaseValidation/python/relval_steps.py
	RecoTracker/DeDx/plugins/HLTDeDxFilter.cc
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_3_X.

More forward porting from CMSSW_7_2_X

It involves the following packages:

Configuration/PyReleaseValidation
EventFilter/FEDInterface
EventFilter/Utilities
HLTrigger/Configuration
RecoTracker/DeDx

@perrotta, @cmsbuild, @nclopezo, @vlimant, @fwyzard, @emeschi, @Martin-Grunewald, @franzoni, @StoyanStoynev, @slava77, @mommsen, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @gpetruc, @cerati, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

+1

correct choices.

But please add #5752 and #5781 to this forward prot now that they are signed by L1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants