Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect EOS Portable Archive from GCCXML #5820

Merged
merged 1 commit into from Oct 17, 2014

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Oct 14, 2014

The following breakes on armv7hl.

basic_binary_oarchive.hpp:80: error: invalid application of 'sizeof' to
incomplete type 'boost::STATIC_ASSERTION_FAILURE<false>'

Static asserts are failing while running inside GCCXML.

The following class from Boost:

class class_id_type {
private:
 typedef int_least16_t base_type;
 base_type t;
};

The size of it is different between GCC 4.2.1 (GCCXML) and GCC 4.91.

There is no need to have those headers in GCCXML, we disabled them
centrally for Boost Serialization. Disable them also here.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

The following breakes on armv7hl.

basic_binary_oarchive.hpp:80: error: invalid application of 'sizeof' to
incomplete type 'boost::STATIC_ASSERTION_FAILURE<false>'

Static asserts are failing while running inside GCCXML.

The following class from Boost:

class class_id_type {
private:
 typedef int_least16_t base_type;
 base_type t;
};

The size of it is different between GCC 4.2.1 (GCCXML) and GCC 4.91.

There is no need to have those headers in GCCXML, we disabled them
centrally for Boost Serialization. Disable them also here.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_3_X.

Protect EOS Portable Archive from GCCXML

It involves the following packages:

CondFormats/HcalObjects

@apfeiffer1, @diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @ggovi can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@apfeiffer1
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlt
Copy link
Contributor Author

davidlt commented Oct 17, 2014

ping^1

@ktf
Copy link
Contributor

ktf commented Oct 17, 2014

Given it compiles and db is ok, I'm merging this… on a friday..

ktf added a commit that referenced this pull request Oct 17, 2014
Protect EOS Portable Archive from GCCXML
@ktf ktf merged commit c7dbe66 into cms-sw:CMSSW_7_3_X Oct 17, 2014
@diguida
Copy link
Contributor

diguida commented Oct 17, 2014

@ktf
Fine for me, sorry for overlooking it :-(

nclopezo added a commit to nclopezo/cmssw that referenced this pull request Oct 21, 2014
…e-archive"

This reverts commit c7dbe66, reversing
changes made to 1b66109.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants