Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix to tracked parameter in ExternalLHEProducer causing spurious run transitions (53x) #5823

Merged
merged 1 commit into from Feb 3, 2015

Conversation

bendavid
Copy link
Contributor

…purious run transitions in production samples
@bendavid
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

@bendavid
Copy link
Contributor Author

-1
Pending understanding of wmagent fix

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_5_3_X.

Backport fix to tracked parameter in ExternalLHEProducer causing spurious run transitions (53x)

It involves the following packages:

GeneratorInterface/LHEInterface

@cmsbuild, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ktf
Copy link
Contributor

ktf commented Nov 3, 2014

Is this understood?

@bendavid
Copy link
Contributor Author

bendavid commented Nov 3, 2014

It's understood, but this pull request is intentionally on hold, since the corresponding updates to wmagent need to be tested/deployed first.

@ghost
Copy link

ghost commented Jan 22, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@bendavid
Copy link
Contributor Author

+1
(Production WMAgents in the process of being patched to handle this properly)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar, @ktf

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 3, 2015
Backport fix to tracked parameter in ExternalLHEProducer causing spurious run transitions (53x)
@cmsbuild cmsbuild merged commit 9014fdc into cms-sw:CMSSW_5_3_X Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants