TrackCountingComputer update for displaced jets #5892
Conversation
|
A new Pull Request was created by @hardenbr for CMSSW_7_3_X. TrackCountingComputer update for displaced jets It involves the following packages: RecoBTag/ImpactParameter @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
|
-1 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC/step4_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVEST+MINIAODMC.log you can see the results of the tests here: |
|
the error seems unrelated, it's happening in other places as well #5891 (comment) |
|
indeed - seems to be new in CMSSW_7_3_X_2014-10-18-0200 On Oct 20, 2014, at 2:41 PM, Slava Krutelyov notifications@github.com
|
|
@davidlange6 How did you determine it came in on CMSSW_7_3_X_2014-10-18-0200? I just checked the IB page for that RelVal and 25202 seems to have run fine there. |
|
it failed here: though it seems not completely reproducible.. perhaps david On Oct 20, 2014, at 3:37 PM, Chris Jones notifications@github.com wrote:
|
|
@ktf Giulio, was the new patch to ROOT 5.34.18 applied at this time? Could be a side-effect of the histogram cloning change I made. |
|
Just checking up on the status of this. From the looks of the error it does not seem obviously related to my changes. |
|
Since the newly introduced parameters are not intended for b tagging and they default values restore the old behavior, I would suggest to keep the cfi files unchanged. |
|
I wanted to make sure there would be a module available with the parameters included when the confDB template is built. If I remove those parameters from the cfi files, will the default template for the TrackCountingComputer include the two new parameters? |
|
Just as I hit the 'Comment' button I realized you might be reusing these cfi files inside the confDB. I'm not very familiar with confDB so I'm not sure if you can introduce new parameters there. I would assume that the default template for the TrackCountingComputer would not include new parameters unless they were already included in the existing cfi files but I might wrong about that. |
RecoBTag/ImpactParameter -- TrackCountingComputer update for displaced jets
Added functionality for tagging displaced jets using the b-tagging track counting computer at HLT. For use in confDB.
Added a minimum impact parameter cut to remove background events which low displacement but high Impact parameter significance.
Added an option to sort tracks using unsigned impact parameter significance. When the a long lived particle (X) decays to two jets and the X is not significantly boosted, one of the jets flight path can be opposite that of the (X). This produces high negative values of Impact parameter significance.
Fragments updated and existAs statements added to produce old behavior.