Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2 Beampipe in All 2023 Scenarios #5895

Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Oct 20, 2014

  • Make Al 2219 parts 1.2 mm thick
  • Add "light" Al 2219 for corrugated structure
  • Simplify some shapes

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_6_2_X_SLHC.

Phase2 Beampipe in All 2023 Scenarios

It involves the following packages:

Geometry/CMSCommonData
Geometry/EcalCommonData
Geometry/ForwardCommonData
Geometry/TrackerCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @argiro, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor Author

ianna commented Oct 20, 2014

@lgray and @fratnikov - this is a complete to a new Phase II beampipe.

+1

@lgray
Copy link
Contributor

lgray commented Oct 20, 2014

@ianna Just to make sure I understand this includes the double thickness Al-2219 beampipe + beampipe taper fix

How should we handle the AlBeMet version, make two separate PRs and study both? To my understanding the geometry was basically taking present beampipe geometry and replacing stainless steel with AlBeMet (except with aluminum bellows?). I guess we should check with Austin and Karl. Could you shoot them a mail?

@bachtis

@ianna
Copy link
Contributor Author

ianna commented Oct 20, 2014

@lgray - yes, I've changed it to 1.2 mm according to an engineering drawing I have. Unfortunately, it covers only a middle part of the beampipe. I'll follow it up with Austin and Karl.

@fratnikov
Copy link

@ianna Does this overwrite #5880?

On 10/20/14 9:29 AM, Ianna Osborne wrote:

@lgray https://github.com/lgray and @fratnikov
https://github.com/fratnikov - this is a complete to a new Phase II
beampipe.

+1


Reply to this email directly or view it on GitHub
#5895 (comment).

@lgray
Copy link
Contributor

lgray commented Oct 20, 2014

@fratnikov Yes, this supersedes #5880 (has correct beampipe thickness)

@mark-grimes
Copy link

merge

cmsbuild added a commit that referenced this pull request Oct 22, 2014
…rios

Phase2 Beampipe in All 2023 Scenarios
@cmsbuild cmsbuild merged commit 700fabd into cms-sw:CMSSW_6_2_X_SLHC Oct 22, 2014
@ianna ianna deleted the phase2-beampipe-in-all-2023-scenarios branch October 26, 2015 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants