Pixel digitizer cleanup

[ahazi137]

Minor changes in pixel digitizer, for details see below:

In pixelDigitizer_cfi.py:

1. The variable “useDB” is set to true. It should be set to false, it is related to a feature which has access to the whole gain calibration DB payload to search for dead-pixels. This has never been implemented and there are no dead pixels in the gain payload.
   line: 50

2. We don't need the variable "AddPixelInefficiency". There is "AddPixelInefficiencyFromPython" instead.
   line: 45

3. Redundant commented variables.
   line: 54-55

In SiPixelDigitizerAlgorithm.cc:

4. There are several places where the first line in a method (e.g. pixel_inefficiency_db) is

if(!...) return

This is unnecessary. The value of this parameter is already known before calling the relevant method.
line: 1712, 1737, 1781

5. In DriftDirection() method the formula to compute the dir_z and scale are the same. We should not calculate it twice.
   e.g. line: 1668

6. In PixelEfficiencies struct we don't need the "if (!...)" block. Variables in this block are used only when "AddPixelInefficiencyFromPython" is true.
   from line: 442

7. Classes PixelBarrelName and PixelEndcapName are not used anymore.
   line: 90-91

8. In PixelAging struct we don't need the "else" block. Variables in this block are used only when AddPixelAging is true.
   from line: 488

9. Some additional corrections of annoying bad indents

[cmsbuild]

A new Pull Request was created by @ahazi137 for CMSSW_7_3_X.

Pixel digitizer cleanup

It involves the following packages:

SimGeneral/MixingModule
SimTracker/SiPixelDigitizer

@cmsbuild, @civanch, @nclopezo, @mdhildreth can you please review it and eventually sign? Thanks.
@wmtan, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @dkotlins, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
Tested at: 32482c7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5912/226/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5912/226/summary.html

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?