Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HcalSourcePosition dataformat and unpacker changes #594

Merged

Conversation

sethcooper
Copy link
Contributor

Updates for HcalSourcePositionData object and relevant unpackers so that they are compatible with data recorded in the H2 testbeam in July 2013.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sethcooper for CMSSW_7_0_X.

HcalSourcePosition dataformat and unpacker changes

It involves the following packages:

DataFormats/HcalRecHit
RecoTBCalo/HcalTBObjectUnpacker

@thspeer, @slava77 can you please review it and eventually sign? Thanks.

@thspeer
Copy link
Contributor

thspeer commented Aug 23, 2013

Working @thspeer

@thspeer
Copy link
Contributor

thspeer commented Aug 23, 2013

+1
Signed - No difference seen
Tested #5a554c6 in (CMSSW_7_0_X_2013-08-23-0200-594)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes.

ktf added a commit that referenced this pull request Aug 23, 2013
…ckers700pre2

HcalSourcePosition dataformat and unpacker changes
@ktf ktf merged commit 8e06a45 into cms-sw:CMSSW_7_0_X Aug 23, 2013
@thuer thuer mentioned this pull request Apr 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants