Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add printout information LHERunInfo.cc and GenXSecAnalyzer.cc #5957

Merged
merged 4 commits into from Oct 23, 2014
Merged

Add printout information LHERunInfo.cc and GenXSecAnalyzer.cc #5957

merged 4 commits into from Oct 23, 2014

Conversation

syuvivida
Copy link
Contributor

Add print out information: cross section before matching, cross section after matching, cross section after filtering. Also add event level efficiency.

@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Oct 23, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @syuvivida for CMSSW_7_3_X.

Eiko 73xpre1

It involves the following packages:

GeneratorInterface/Core
GeneratorInterface/LHEInterface

@vciulli, @covarell, @thuer, @cmsbuild, @nclopezo, @bendavid can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@syuvivida
Copy link
Contributor Author

An example of log file is here: http://syu.web.cern.ch/syu/Logana-2
See the bottom of the log file. The first print out comes from LHERunInfo, and the second comes from GenXSecAnalyzer

@syuvivida syuvivida mentioned this pull request Oct 23, 2014
Closed
@bendavid
Copy link
Contributor

Hi Eiko,
I assume the filter efficiency will also properly take into account arbitrary weighted events? (as opposed to just equal positive and negative weights?)

@syuvivida
Copy link
Contributor Author

Yes. it does calculate filter efficiency correctly based on hepidwtup_. If hepidwtup_ is -3 or +3, it will only use the number of events with positive or negative weights. If hepidwtup is something else, then, it will sum up the weights. The print out is a bit confusing. I have made a small modification. See the log file here again:http://syu.web.cern.ch/syu/Logana-2

@cmsbuild
Copy link
Contributor

Pull request #5957 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @nclopezo, @bendavid can you please check and sign again.

@bendavid
Copy link
Contributor

Wouldn't it be more general to just say "taking into account weights"?

@bendavid
Copy link
Contributor

(Also can you please edit the name of the pull request to something a bit more descriptive?)

@cmsbuild
Copy link
Contributor

+1
Tested at: 606e0a8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5957/307/summary.html

@cmsbuild
Copy link
Contributor

Pull request #5957 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @nclopezo, @bendavid can you please check and sign again.

@syuvivida
Copy link
Contributor Author

The printout is edited. See the updated format here:http://syu.web.cern.ch/syu/Logana-2

@syuvivida syuvivida changed the title Eiko 73xpre1 Add printout information LHERunInfo.cc and GenXSecAnalyzer.cc Oct 23, 2014
@bendavid
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5957/307/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

+1
Tested at: 7793184
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5957/314/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Oct 23, 2014
@nclopezo
Merge pull request #5957 from syuvivida/eiko_73xpre1
06bbefc 
GeneratorInterface -- Add printout information LHERunInfo.cc and GenXSecAnalyzer.cc
@nclopezo nclopezo merged commit 06bbefc into cms-sw:CMSSW_7_3_X Oct 23, 2014
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5957/314/summary.html

bendavid pushed a commit to bendavid/cmssw that referenced this pull request Nov 11, 2014
@nclopezo @bendavid
Merge pull request cms-sw#5957 from syuvivida/eiko_73xpre1
869e916 
GeneratorInterface -- Add printout information LHERunInfo.cc and GenXSecAnalyzer.cc
Resolved Conflicts:
	GeneratorInterface/Core/interface/GenXSecAnalyzer.h
	GeneratorInterface/Core/plugins/GenXSecAnalyzer.cc
bendavid pushed a commit to bendavid/cmssw that referenced this pull request Jan 12, 2015
@nclopezo @bendavid
Merge pull request cms-sw#5957 from syuvivida/eiko_73xpre1
91f26f6 
GeneratorInterface -- Add printout information LHERunInfo.cc and GenXSecAnalyzer.cc
hroskes pushed a commit to hroskes/cmssw that referenced this pull request Feb 12, 2015
@nclopezo @hroskes
Merge pull request cms-sw#5957 from syuvivida/eiko_73xpre1
c6af1e3 
GeneratorInterface -- Add printout information LHERunInfo.cc and GenXSecAnalyzer.cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed generators-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@syuvivida @cmsbuild @bendavid @nclopezo