Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rel val upgradeto pythia8 commonblocks #5960

Merged
merged 10 commits into from Oct 24, 2014
Merged

Rel val upgradeto pythia8 commonblocks #5960

merged 10 commits into from Oct 24, 2014

Conversation

inugent
Copy link
Contributor

@inugent inugent commented Oct 23, 2014

replaces pr 5840 with request from Josh on the naming convention.

@cmsbuild cmsbuild added this to the Next CMSSW_7_3_X milestone Oct 23, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @inugent for CMSSW_7_3_X.

Rel val upgradeto pythia8 commonblocks

It involves the following packages:

Configuration/Generator
Configuration/PyReleaseValidation

@vciulli, @covarell, @vlimant, @thuer, @cmsbuild, @franzoni, @nclopezo, @bendavid, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
Tested at: aba97b2
I found an error when building:

sh: /cvmfs/cms-ib.cern.ch/2014-43/slc6_amd64_gcc481/external/gmake/3.81/bin/gmake: Input/output error
gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 126

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5960/324/summary.html

@bendavid
Copy link
Contributor

@cmsbuild I think this failure is unrelated to the pull request

@franzoni
Copy link

+1
The GEN-SIM which is affected by this PR is ok. Nearly all relvals in the matrix fail, but for a different reason.

@bendavid
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

+1
Tested at: aba97b2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5960/348/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Oct 24, 2014
@nclopezo
Merge pull request #5960 from inugent/RelValUpgradetoPythia8Commonblocks
698756e 
Rel val upgrade to pythia8 common blocks
@nclopezo nclopezo merged commit 698756e into cms-sw:CMSSW_7_3_X Oct 24, 2014
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5960/348/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed generators-approved operations-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_7_3_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@inugent @cmsbuild @bendavid @franzoni @nclopezo