Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram booking moved to beginRun #60

Merged
merged 1 commit into from Jul 24, 2013
Merged

Histogram booking moved to beginRun #60

merged 1 commit into from Jul 24, 2013

Conversation

dinardo
Copy link
Contributor

@dinardo dinardo commented Jul 8, 2013

No description provided.

@ktf
Copy link
Contributor

ktf commented Jul 9, 2013

@rovere, @deguio can you please look into this?

@nclopezo
Copy link
Contributor

Hi,

I took CMSSW_7_0_X_2013-07-12-0200, pulled these changes and ran the unit tests and Relvals. All the tests passed.

@dinardo
Copy link
Contributor Author

dinardo commented Jul 12, 2013

Dear Experts,
I received this email.
What shall I do now ?

Here it says "Signature pending" :
https://cmsgit.web.cern.ch/cmsgit/cmsgit/#CMSSW_7_0_X

Many thanks,

  • Mauro.

On Jul 12, 2013, at 10:50 AM, nclopezo <notifications@github.commailto:notifications@github.com> wrote:

Hi,

I took CMSSW_7_0_X_2013-07-12-0200, pulled this changes and run the unit tests and Relvals. All the tests passed.


Reply to this email directly or view it on GitHubhttps://github.com//pull/60#issuecomment-20865294.

@davidlt
Copy link
Contributor

davidlt commented Jul 12, 2013

@dinardo , It needs to be signed by DQM L2 managers. If you go the link you should see that this change set is pending a signature from DQM.

@ktf
Copy link
Contributor

ktf commented Jul 16, 2013

@rovere, @deguio is anything holding this up?

@cmsbuild
Copy link
Contributor

The following categories have been rejected by @deguio: DQM

@cms-git-dqm

@deguio
Copy link
Contributor

deguio commented Jul 19, 2013

The topic is merged into the pull request 144. I had to solve a conflict in the authors name. This is the reason why I reject this one.

@dinardo
Copy link
Contributor Author

dinardo commented Jul 19, 2013

I don't understand.
What shall I do ?
Am I suppose to take an action ?

Thanks for the clarification.

  • Mauro.

On Jul 19, 2013, at 5:02 PM, deguio <notifications@github.commailto:notifications@github.com> wrote:

The topic is merged into the pull request 144. I had to solve a conflict in the authors name. This is the reason why I reject this one.


Reply to this email directly or view it on GitHubhttps://github.com//pull/60#issuecomment-21254912.

@deguio
Copy link
Contributor

deguio commented Jul 19, 2013

@dinardo nope. no actions are needed from your side (at the moment ;) ).
thanks,
F.

smuzaffar added a commit that referenced this pull request Jul 24, 2013
@smuzaffar smuzaffar merged commit 3b1d1b6 into cms-sw:CMSSW_7_0_X Jul 24, 2013
nclopezo added a commit to nclopezo/cmssw that referenced this pull request May 5, 2014
added a regular expression to identify special releases
gdimperi pushed a commit to gdimperi/cmssw that referenced this pull request Jun 21, 2015
…enuisance-fits

Speedup fits with discrete nuisances.
gpetruc pushed a commit to gpetruc/cmssw that referenced this pull request Aug 13, 2015
MT2 cfg: fix switches to run on data
arizzi pushed a commit to arizzi/cmssw that referenced this pull request Dec 17, 2015
Several Jet related fixes and features from VHbb
mariadalfonso pushed a commit to mariadalfonso/cmssw that referenced this pull request May 6, 2017
cmsbuild pushed a commit that referenced this pull request Oct 17, 2017
Increase gamma Et threshold for tau reco&id
mseidel42 pushed a commit to mseidel42/cmssw that referenced this pull request Oct 31, 2017
Muon ntracker layer  and update cms driver
makortel pushed a commit to makortel/cmssw that referenced this pull request Jun 23, 2018
  - the CPU Riemann fit works using all combinations between the 2 booleans: `useErrors` and `useMultipleScattering`;
  - the standalone version of the GPU Riemann fit has been updated in order to explore all possibilities among the 2 booleans above: all of them work and produce identical results up to 1e-5 precision (the default one, 1e-6 fails when enabling multiScattering, most likely due to matrix inversions);
  - the GPU version of the Riemann fit within CMSSW works, with 1 fit assigned to each thread, with 32 threads/warps, all dynamically computed.

Things that needs a "hack":

  - limit the "dynamic" size of Eigen matrices to at most, 4x4, which is just fine for quadruplets. Using anything wider will cause errors which I *believe* is related to the stack size of threads on the GPU;
  - cast matrices to be inverted to 4x4 (was done before the previous point: will revert it back and see if that's still needed or not, but I believe it is); this was done in order to "specialize" the `invert()` call to something that is "natively" supported by Eigen on GPU (that brought in also few `__host__` `__device__` here and there in Eigen);
  - fix the alignment of the `struct` holding the results of the fit, since its size was different on GPU and CPU, causing an annoying off-by-one effect.
tahuang1991 pushed a commit to tahuang1991/cmssw that referenced this pull request Sep 13, 2018
…numbering_Tao

update CSCTriggerPrimitivesReader to select the pretrigger with highe…
gpetruc pushed a commit to gpetruc/cmssw that referenced this pull request Oct 29, 2019
tomalin added a commit to tomalin/cmssw that referenced this pull request Jan 5, 2021
* Add MCsamples access to MC

* Add MCsamples access to MC
aehart pushed a commit to aehart/cmssw that referenced this pull request Jan 25, 2021
* Add MCsamples access to MC

* Add MCsamples access to MC
tomalin added a commit to tomalin/cmssw that referenced this pull request Mar 3, 2021
* Add MCsamples access to MC

* Add MCsamples access to MC
drankincms pushed a commit to drankincms/cmssw that referenced this pull request Mar 9, 2022
Update recipe & add hooks to run deregionizer + seeded-cone jets emulator
yulunmiao pushed a commit to yulunmiao/cmssw that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants