GenHFHadronMatcher using the official JetFlavour tool for hadron-jet association

[bartosik-hep]

In the GenHFHadronMacther tool the custom implementation of ghost hadron injection replaced by the new official JetFlavour identification tool.
Improved chain scanning performance.
Fixed issues with low origin identification efficiency in Pythia8.

[cmsbuild]

A new Pull Request was created by @bartosik-desy (Nazar Bartosik) for CMSSW_7_3_X.

GenHFHadronMatcher using the official JetFlavour tool for hadron-jet association

It involves the following packages:

PhysicsTools/JetMCAlgos

@cmsbuild, @vadler, @nclopezo, @monttj can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

+1
Tested at: 294351d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6012/391/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6012/391/summary.html

[vadler]

getByToken

[vadler]

-1
Tested on top of CMSSW_7_3_X_2014-10-27-1400.
I changed the input in PhysicsTools/JetMCAlgos/test/genHFHadronMatcher.py to '/store/relval/CMSSW_7_2_0_pre7/RelValTTbar_13/GEN-SIM-RECO/PU50ns_PRE_LS172_V12-v1/00000/1267B7ED-2F4E-E411-A0B9-0025905964A6.root' to make it run (at CERN), which works fine w/o this PR, but crashes now with

----- Begin Fatal Exception 28-Oct-2014 12:13:00 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=GenHFHadronMatcher label='matchGenBHadron'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'genParticles'
 'jetFlavourInfos'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

[vadler]

@bartosik-desy : The test runs fine now also for me.
Adjusting the number of events, I observe differences in the output file. Are these expected (to that amount)?

[bartosik-hep]

@vadler I'm not sure what differences you are referring to. In principle changing the number of processed events will change the number of analysed hadrons. Since there can be some rare cases where hadrons originate from there can be some changes in branches including genBHadFlavour or genBHadIndex. But at high statistics those changes are negligible.

[vadler]

@bartosik-desy : I simply compared arbitrary variables in genHFHadronMatcher_out.root, running on 100 events in both cases (where you increased it to 1000 with this PR). S. some examples below

[bartosik-hep]

@vadler These differences are small and expected due to change of the tool that is doing the hadron-jet matching and change of the default configuration to analyse only hadrons that are associated to jets, which improves performance and is enough for most of the analyses.

[vadler]

@bartosik-desy : Thanx for the confirmation.

[vadler]

+1
Tested on top of CMSSW_7_3_X_2014-10-29-1400.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.