Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HE recalibration for radiation damage scenarios #6035

Merged
merged 4 commits into from Oct 28, 2014

Conversation

kpedro88
Copy link
Contributor

This pull request:

  1. extends the addition of a "scenario" parameter for HEDarkening (5916) to HERecalibration;
  2. picks up some optimizations to HERecalibration which had not yet been backported to 62XSLHC (see 7XX history);
  3. creates a Python customization function "set_HE_aging_scenario" in aging.py, which can easily be added to the end of config files to ensure agreement between the HEDarkening scenario and the HERecalibration scenario settings;
  4. fixes a few bugs in the HE aging scenario definitions.

It has been tested using upgrade configuration 11861 in runTheMatrix, to make sure that the calculation of recalibration factors changes appropriately based on the chosen scenario.

@ktf
Copy link
Contributor

ktf commented Oct 28, 2014

Just for the record, you can use "#5916" (i.e. #<pull-request-id>) to refer automatically to other pull requests.

@kpedro88
Copy link
Contributor Author

Ah, thanks! I actually might have known that before, but after spending several months writing my thesis, I have found that some refreshers are necessary.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_6_2_X_SLHC.

HE recalibration for radiation damage scenarios

It involves the following packages:

CalibCalorimetry/HcalPlugins
DataFormats/HcalCalibObjects
SLHCUpgradeSimulations/Configuration

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @diguida, @rcastello, @cerminar, @mmusich can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fratnikov
Copy link

merge

cmsbuild added a commit that referenced this pull request Oct 28, 2014
HE recalibration for radiation damage scenarios
@cmsbuild cmsbuild merged commit 32d3371 into cms-sw:CMSSW_6_2_X_SLHC Oct 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants