Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes for large object passed by value found by clang static analyzer cms.ArgSizeChecker #618

Merged
merged 1 commit into from
Aug 28, 2013
Merged

changes for large object passed by value found by clang static analyzer cms.ArgSizeChecker #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion HLTrigger/Egamma/interface/HLTEgammaAllCombMassFilter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class HLTEgammaAllCombMassFilter : public HLTFilter {
explicit HLTEgammaAllCombMassFilter(const edm::ParameterSet&);
~HLTEgammaAllCombMassFilter();
virtual bool hltFilter(edm::Event&, const edm::EventSetup&, trigger::TriggerFilterObjectWithRefs & filterproduct);
static void getP4OfLegCands(const edm::Event& iEvent,edm::InputTag filterTag,std::vector<math::XYZTLorentzVector>& p4s);
static void getP4OfLegCands(const edm::Event& iEvent,const edm::InputTag& filterTag,std::vector<math::XYZTLorentzVector>& p4s);

private:
edm::InputTag firstLegLastFilterTag_;
Expand Down
2 changes: 1 addition & 1 deletion HLTrigger/Egamma/interface/HLTEgammaCaloIsolFilterPairs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class HLTEgammaCaloIsolFilterPairs : public HLTFilter {


bool AlsoNonIso_1,AlsoNonIso_2;
bool PassCaloIsolation(edm::Ref<reco::RecoEcalCandidateCollection> ref,reco::RecoEcalCandidateIsolationMap IsoMap,reco::RecoEcalCandidateIsolationMap NonIsoMap, int which, bool ChekAlsoNonIso);
bool PassCaloIsolation(edm::Ref<reco::RecoEcalCandidateCollection> ref,const reco::RecoEcalCandidateIsolationMap& IsoMap,const reco::RecoEcalCandidateIsolationMap& NonIsoMap, int which, bool ChekAlsoNonIso);
};

#endif //HLTEgammaCaloIsolFilterPairs_h
Expand Down
2 changes: 1 addition & 1 deletion HLTrigger/Egamma/interface/HLTEgammaCombMassFilter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class HLTEgammaCombMassFilter : public HLTFilter {
explicit HLTEgammaCombMassFilter(const edm::ParameterSet&);
~HLTEgammaCombMassFilter();
virtual bool hltFilter(edm::Event&, const edm::EventSetup&, trigger::TriggerFilterObjectWithRefs & filterproduct);
static void getP4OfLegCands(const edm::Event& iEvent,edm::InputTag filterTag,std::vector<math::XYZTLorentzVector>& p4s);
static void getP4OfLegCands(const edm::Event& iEvent,const edm::InputTag& filterTag,std::vector<math::XYZTLorentzVector>& p4s);

private:
edm::InputTag firstLegLastFilterTag_;
Expand Down
2 changes: 1 addition & 1 deletion HLTrigger/Egamma/interface/HLTEgammaDoubleLegCombFilter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class HLTEgammaDoubleLegCombFilter : public HLTFilter {
~HLTEgammaDoubleLegCombFilter();
virtual bool hltFilter(edm::Event&, const edm::EventSetup&, trigger::TriggerFilterObjectWithRefs & filterproduct);
void matchCands(const std::vector<math::XYZPoint>& firstLegP3s,const std::vector<math::XYZPoint>& secondLegP3s,std::vector<std::pair<int,int> >&matchedCands);
static void getP3OfLegCands(const edm::Event& iEvent,edm::InputTag filterTag,std::vector<math::XYZPoint>& p3s);
static void getP3OfLegCands(const edm::Event& iEvent,const edm::InputTag& filterTag,std::vector<math::XYZPoint>& p3s);

private:
edm::InputTag firstLegLastFilterTag_;
Expand Down
2 changes: 1 addition & 1 deletion HLTrigger/Egamma/src/HLTEgammaAllCombMassFilter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ bool HLTEgammaAllCombMassFilter::hltFilter(edm::Event& iEvent, const edm::EventS
return accept;
}

void HLTEgammaAllCombMassFilter::getP4OfLegCands(const edm::Event& iEvent,edm::InputTag filterTag,std::vector<math::XYZTLorentzVector>& p4s)
void HLTEgammaAllCombMassFilter::getP4OfLegCands(const edm::Event& iEvent,const edm::InputTag& filterTag,std::vector<math::XYZTLorentzVector>& p4s)
{
edm::Handle<trigger::TriggerFilterObjectWithRefs> filterOutput;
iEvent.getByLabel(filterTag,filterOutput);
Expand Down
2 changes: 1 addition & 1 deletion HLTrigger/Egamma/src/HLTEgammaCaloIsolFilterPairs.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ HLTEgammaCaloIsolFilterPairs::hltFilter(edm::Event& iEvent, const edm::EventSetu
return accept;
}

bool HLTEgammaCaloIsolFilterPairs::PassCaloIsolation(edm::Ref<reco::RecoEcalCandidateCollection> ref,reco::RecoEcalCandidateIsolationMap IsoMap,reco::RecoEcalCandidateIsolationMap NonIsoMap, int which, bool ChekAlsoNonIso){
bool HLTEgammaCaloIsolFilterPairs::PassCaloIsolation(edm::Ref<reco::RecoEcalCandidateCollection> ref,const reco::RecoEcalCandidateIsolationMap& IsoMap,const reco::RecoEcalCandidateIsolationMap& NonIsoMap, int which, bool ChekAlsoNonIso){


reco::RecoEcalCandidateIsolationMap::const_iterator mapi = IsoMap.find( ref );
Expand Down
2 changes: 1 addition & 1 deletion HLTrigger/Egamma/src/HLTEgammaCombMassFilter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ bool HLTEgammaCombMassFilter::hltFilter(edm::Event& iEvent, const edm::EventSetu
return accept;
}

void HLTEgammaCombMassFilter::getP4OfLegCands(const edm::Event& iEvent,edm::InputTag filterTag,std::vector<math::XYZTLorentzVector>& p4s)
void HLTEgammaCombMassFilter::getP4OfLegCands(const edm::Event& iEvent,const edm::InputTag& filterTag,std::vector<math::XYZTLorentzVector>& p4s)
{
edm::Handle<trigger::TriggerFilterObjectWithRefs> filterOutput;
iEvent.getByLabel(filterTag,filterOutput);
Expand Down
2 changes: 1 addition & 1 deletion HLTrigger/Egamma/src/HLTEgammaDoubleLegCombFilter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ void HLTEgammaDoubleLegCombFilter::matchCands(const std::vector<math::XYZPoint>
}

//we use position and p3 interchangably here, we only use eta/phi so its alright
void HLTEgammaDoubleLegCombFilter::getP3OfLegCands(const edm::Event& iEvent,edm::InputTag filterTag,std::vector<math::XYZPoint>& p3s)
void HLTEgammaDoubleLegCombFilter::getP3OfLegCands(const edm::Event& iEvent,const edm::InputTag& filterTag,std::vector<math::XYZPoint>& p3s)
{
edm::Handle<trigger::TriggerFilterObjectWithRefs> filterOutput;
iEvent.getByLabel(filterTag,filterOutput);
Expand Down
2 changes: 1 addition & 1 deletion HLTriggerOffline/SUSYBSM/interface/McSelector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class McSelector {
public:

//Constructor
McSelector(edm::ParameterSet userCut_params);
McSelector(const edm::ParameterSet& userCut_params);
//Destructor
virtual ~McSelector(){};

Expand Down
2 changes: 1 addition & 1 deletion HLTriggerOffline/SUSYBSM/interface/MuonAnalyzer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
class MuonAnalyzerSBSM {

public:
MuonAnalyzerSBSM(edm::InputTag, edm::InputTag);
MuonAnalyzerSBSM(const edm::InputTag&, const edm::InputTag&);
virtual ~MuonAnalyzerSBSM(){};

void InitializePlots(DQMStore *, const std::string);
Expand Down
2 changes: 1 addition & 1 deletion HLTriggerOffline/SUSYBSM/interface/PlotMakerL1.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
class PlotMakerL1 {

public:
PlotMakerL1(edm::ParameterSet objectList);
PlotMakerL1(const edm::ParameterSet& objectList);
virtual ~PlotMakerL1(){};

void handleObjects(const edm::Event&);
Expand Down
2 changes: 1 addition & 1 deletion HLTriggerOffline/SUSYBSM/interface/PlotMakerReco.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
class PlotMakerReco {

public:
PlotMakerReco(edm::ParameterSet objectList);
PlotMakerReco(const edm::ParameterSet& objectList);
virtual ~PlotMakerReco(){};

void handleObjects(const edm::Event&);
Expand Down
2 changes: 1 addition & 1 deletion HLTriggerOffline/SUSYBSM/interface/RecoSelector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class RecoSelector {
public:

//Constructor
RecoSelector(edm::ParameterSet userCut_params);
RecoSelector(const edm::ParameterSet& userCut_params);
//Destructor
virtual ~RecoSelector(){};

Expand Down
2 changes: 1 addition & 1 deletion HLTriggerOffline/SUSYBSM/src/McSelector.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ using namespace edm;
using namespace reco;
using namespace std;

McSelector::McSelector(edm::ParameterSet userCut_params)
McSelector::McSelector(const edm::ParameterSet& userCut_params)
{
//******************** PLEASE PAY ATTENTION: number of electron and muons is strictly equal, for jets, taus and photons the requirement is >= ********************
name = userCut_params.getParameter<string>("name");
Expand Down
2 changes: 1 addition & 1 deletion HLTriggerOffline/SUSYBSM/src/MuonAnalyzer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ using namespace std;
using namespace trigger;


MuonAnalyzerSBSM::MuonAnalyzerSBSM(edm::InputTag triggerTag_v, edm::InputTag muonTag_v)
MuonAnalyzerSBSM::MuonAnalyzerSBSM(const edm::InputTag& triggerTag_v, const edm::InputTag& muonTag_v)
{
triggerTag_ = triggerTag_v;
muonTag_ = muonTag_v;
Expand Down
2 changes: 1 addition & 1 deletion HLTriggerOffline/SUSYBSM/src/PlotMakerL1.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ using namespace reco;
using namespace std;
using namespace l1extra;

PlotMakerL1::PlotMakerL1(edm::ParameterSet PlotMakerL1Input)
PlotMakerL1::PlotMakerL1(const edm::ParameterSet& PlotMakerL1Input)
{
m_l1extra = PlotMakerL1Input.getParameter<string>("l1extramc");

Expand Down
2 changes: 1 addition & 1 deletion HLTriggerOffline/SUSYBSM/src/PlotMakerReco.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ using namespace reco;
using namespace std;
using namespace l1extra;

PlotMakerReco::PlotMakerReco(edm::ParameterSet PlotMakerRecoInput)
PlotMakerReco::PlotMakerReco(const edm::ParameterSet& PlotMakerRecoInput)
{
m_electronSrc = PlotMakerRecoInput.getParameter<string>("electrons");
m_muonSrc = PlotMakerRecoInput.getParameter<string>("muons");
Expand Down
2 changes: 1 addition & 1 deletion HLTriggerOffline/SUSYBSM/src/RecoSelector.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ using namespace edm;
using namespace reco;
using namespace std;

RecoSelector::RecoSelector(edm::ParameterSet userCut_params)
RecoSelector::RecoSelector(const edm::ParameterSet& userCut_params)
{

name = userCut_params.getParameter<string>("name");
Expand Down