Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a fix for SUB=TH1F::Sumw2 error in DQM/Physics package #6241

Merged
merged 1 commit into from Nov 7, 2014

Conversation

anorkus
Copy link
Contributor

@anorkus anorkus commented Nov 6, 2014

A fix needed for issue found in here : #6177
Adds a check if Sumw2 call was done before.
Before when running a workflow (4.6) where multiple runs were processed bookHistograms method was called one than once and it triggered a "Sum of squares of weights structure already created" error.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

A new Pull Request was created by @anorkus (Antanas Norkus) for CMSSW_7_3_X.

a fix for SUB=TH1F::Sumw2 error in DQM/Physics package

It involves the following packages:

DQM/Physics

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @ojeda can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

@deguio
Copy link
Contributor

deguio commented Nov 7, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 7, 2014
a fix for SUB=TH1F::Sumw2 error in DQM/Physics package
@cmsbuild cmsbuild merged commit 2f3b366 into cms-sw:CMSSW_7_3_X Nov 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants