Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codes required to do multiple hadronization and to print out cross section including HepMCFilter efficiency #6259

Closed
wants to merge 6 commits into from

Conversation

syuvivida
Copy link
Contributor

The code change includes

  1. Josh's update which allows input lhe files to be hadronized multiple times in
    order to boost the matching/filter efficiency.

  2. Eiko's update in GenXSectionAnalyzer, HadronizerFilter, and HepMCFilterDriver:
    Additional GenFilterInfo with process name = "generator" is saved so to retrieve the filter efficiency of HepMCFilter and to compute cross section correctly.

bendavid and others added 6 commits October 25, 2014 00:20
… plus hooks for additional HepMC level filtering at this stage and an example filter already useful for selecting JPsi->mu mu decays

Resolved Conflicts:
	GeneratorInterface/Core/interface/HadronizerFilter.h
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2014

A new Pull Request was created by @syuvivida for CMSSW_7_3_X.

Codes required to do multiple hadronization and to print out cross section including HepMCFilter efficiency

It involves the following packages:

GeneratorInterface/Core
GeneratorInterface/HepMCFilters

The following packages do not have a category, yet:

GeneratorInterface/HepMCFilters

@vciulli, @covarell, @thuer, @cmsbuild, @nclopezo, @bendavid can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@bendavid
Copy link
Contributor

bendavid commented Nov 6, 2014

+1

@bendavid
Copy link
Contributor

bendavid commented Nov 6, 2014

The new package here is GeneratorInterface/HepMCFilters which defines a new interface (plus first implementation) for HepMCFilters which allow to filter on the HepMCEvent inside the hadronizer loop. (So a reasonable sized lhe sample can be used together with hadronization-level filters)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2014

@davidlange6
Copy link
Contributor

@bendavid - could the files in the new package just go to Gen.../Core (which in any case depends on the new package) - unless you are expecting this new package to grow a lot, it seems a practical solution.

@bendavid
Copy link
Contributor

@davidlange6 we expect that this package will be updated relatively more frequently than GenInterface/Core as new filters are added. (Any new filter intended to be used with an lhe-based request will have to be added here.)

There was a discussion about this by mail some months ago which I will re-forward. (It took some time to properly test and converge on the final pull request since then.)

@davidlange6
Copy link
Contributor

Seeing that now most of the GenInterface/Core filters now depend on the new package, I would prefer to use the Core package until we see the pace of new filters being added unless there is a dependency issue that I'm missing

(as in any case, we'll have to checkout and recompile Core when these others are updated)

@bendavid
Copy link
Contributor

So indeed the reason to make a new package instead of putting everything in Core was organizational rather than technical. I'll move things back into Core since that seems to be preferred.

@bendavid
Copy link
Contributor

-1
Superseded by #6319 (which gets rid of the new package and moves everything into Core as requested)

@bendavid
Copy link
Contributor

(this can be closed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants