Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making dEtaIn seed available for ID purposes #6300

Merged
merged 2 commits into from Nov 10, 2014

Conversation

Sam-Harper
Copy link
Contributor

This pull request simplifies the calculation of the new ID variable dEtaInSeed presented recently in the e/gamma meeting. As the name suggests, it is dEtaIn but computed using the eta of the seed cluster rather than the supercluster. It is simply dEtaIn-sc eta + seed eta. I have added a function to GsfElectron which makes it, it would be nice if we could have this, it just simplifies things and avoids mistakes but we can live without.

I have also added a class to the ID framework which can cut on this variable.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2014

A new Pull Request was created by @Sam-Harper for CMSSW_7_3_X.

Making dEtaIn seed available for ID purposes

It involves the following packages:

DataFormats/EgammaCandidates
RecoEgamma/ElectronIdentification

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@StoyanStoynev
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
Tested 1da8e96 on top of CMSSW_7_3_X_2014-11-09-1400 - short matrix tests. No diffs (despite false positives in jenkins). The code only adds optional function and a class (that is - not run by default).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

cmsbuild added a commit that referenced this pull request Nov 10, 2014
Making dEtaIn seed available for ID purposes
@cmsbuild cmsbuild merged commit 203c2e8 into cms-sw:CMSSW_7_3_X Nov 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants