Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If unit test fails, return a non-zero exit code #6317

Merged
merged 1 commit into from Nov 11, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Nov 10, 2014

This pull request affects unit tests only.
Many unit tests in CondCore/* packages return a zero return value even if the test fails. This causes failures to not be reported as failures in the IB.
In the ROOT 6 IB, there were approximately 15 test failures that were not noticed until now because of this.
Since these code changes are not ROOT 6 specific, they are being pull requested in the main 7_3_X branch for code commonality.
Fortunately. all the affected unit tests pass in the 7_3_X IB.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_3_X.

If unit test fails, return a non-zero exit code

It involves the following packages:

CondCore/DBCommon
CondCore/IOVService
CondCore/ORA

@apfeiffer1, @nclopezo, @cerminar, @cmsbuild, @diguida, @rcastello, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@apfeiffer1
Copy link
Contributor

+1
Thanks, Bill !

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @nclopezo, @ktf, @ktf, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @nclopezo, @ktf, @ktf, @davidlange6, @smuzaffar

@ktf
Copy link
Contributor

ktf commented Nov 11, 2014

This is trivial (and annoying) enough to be bypassed.

ktf added a commit that referenced this pull request Nov 11, 2014
If unit test fails, return a non-zero exit code
@ktf ktf merged commit 21bf577 into cms-sw:CMSSW_7_3_X Nov 11, 2014
@cmsbuild
Copy link
Contributor

@wmtan wmtan deleted the ReturnNonZeroIfUnitTestFails branch November 11, 2014 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants