New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If unit test fails, return a non-zero exit code #6317
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_3_X. If unit test fails, return a non-zero exit code It involves the following packages: CondCore/DBCommon @apfeiffer1, @nclopezo, @cerminar, @cmsbuild, @diguida, @rcastello, @ggovi, @mmusich can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @nclopezo, @ktf, @ktf, @davidlange6, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @nclopezo, @ktf, @ktf, @davidlange6, @smuzaffar |
This is trivial (and annoying) enough to be bypassed. |
If unit test fails, return a non-zero exit code
This pull request affects unit tests only.
Many unit tests in CondCore/* packages return a zero return value even if the test fails. This causes failures to not be reported as failures in the IB.
In the ROOT 6 IB, there were approximately 15 test failures that were not noticed until now because of this.
Since these code changes are not ROOT 6 specific, they are being pull requested in the main 7_3_X branch for code commonality.
Fortunately. all the affected unit tests pass in the 7_3_X IB.