Flag candidate merged clusters for relaxed CPE errors #6348
Conversation
|
A new Pull Request was created by @wmtford for CMSSW_7_3_X. Flag candidate merged clusters for relaxed CPE errors It involves the following packages: DataFormats/SiStripCluster @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
|
Closing in favor of PR #6349, which based on a newer release, and is mergeable. |
| SiStripDetInfoFileReader* reader = 0; | ||
| if (doRefineCluster_) { | ||
| es.get<SiStripQualityRcd>().get("", quality); | ||
| reader = edm::Service<SiStripDetInfoFileReader>().operator->(); |
There was a problem hiding this comment.
@slava77 does the SiStripDetInfoFileReader Service affect the physics results? If so, then this is an illegal use of a Service.
There was a problem hiding this comment.
Chris,
do you mean that we should use ES or some plugin factory?
There was a problem hiding this comment.
Either of those two or it might be possible to just make it a member data of the producer itself.
Add a function "refineCluster" in SiStripClusterizer to mark SiStrip clusters as merged. Use this information StripCPEfromTrackAngle to fall back to the larger "legacy" CPE errors for these clusters. The flag lives on the high bit of the firstStrip_ private data member of the SiStripCluster. Configurable thresholds in the sensor occupancy and strip width are used to discriminate between un- and merged candidates. The cluster refiner is turned off as configured for this PR.