-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix for pixel clustershape filter, and, change HI tracking low-pt seeding from triplet to track #6376
bugfix for pixel clustershape filter, and, change HI tracking low-pt seeding from triplet to track #6376
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,6 +56,7 @@ PixelTrackReconstruction::PixelTrackReconstruction(const ParameterSet& cfg, | |
if(theConfig.exists("useFilterWithES")) { | ||
edm::LogInfo("Obsolete") << "useFilterWithES parameter is obsolete and can be removed"; | ||
} | ||
useClusterShape = filterPSet.exists("useClusterShape"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should also the value of useClusterShape parameter be checked (in addition of its existence)? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, this is just tells you whether the class inherits from On 11/13/14 3:52 PM, Matti Kortelainen wrote:
Matthew Nguyen +33 1 69 33 55 65There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, right, and the filter itself checks the value. Got it, thanks. |
||
} | ||
|
||
ParameterSet orderedPSet = | ||
|
@@ -129,10 +130,12 @@ void PixelTrackReconstruction::run(TracksWithTTRHs& tracks, edm::Event& ev, cons | |
reco::Track* track = theFitter->run( ev, es, hits, region); | ||
if (!track) continue; | ||
|
||
// decide if track should be skipped according to filter | ||
if (theFilter && !(*theFilter)(track, hits) ) { | ||
delete track; | ||
continue; | ||
if (theFilter) { | ||
if ((useClusterShape && !(*theFilter)(track, hits, tTopo)) || | ||
(!useClusterShape && !(*theFilter)(track, hits))) { | ||
delete track; | ||
continue; | ||
} | ||
} | ||
|
||
// add tracks | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe forward declare it?