Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

70X additional b-taggers #644

Merged
merged 6 commits into from Sep 2, 2013

Conversation

ferencek
Copy link
Contributor

Updates corresponding to the CVS tag change V01-04-11 --> V01-04-13 of RecoBTag/ImpactParameter

  • additional negative and positive taggers added to RecoBTag/ImpactParameter/python/impactParameter_cff.py
  • bugfix for negative and positive jet probability b-taggers (added missing variable JTA parameters)

Updates corresponding to the CVS tag change V01-08-03 --> V01-11-02 of RecoBTag/SecondaryVertex

  • added retrained CSV (CSVV1) and double SV taggers

Updates corresponding to the CVS tag change V05-09-10 --> V05-09-11 of RecoBTag/SoftLepton

  • recovered softMuonTagInfos

Updates corresponding to the CVS tag change V02-03-00 --> V02-03-02 of RecoBTau/JetTagComputer

  • added super-combined CSV + soft lepton (CSVSLV1) tagger

…f RecoBTag/ImpactParameter

- additional negative and positive taggers added to RecoBTag/ImpactParameter/python/impactParameter_cff.py

- bugfix for negative and positive jet probability b-taggers (added missing variable JTA parameters)
…f RecoBTag/SecondaryVertex

- added retrained CSV (CSVV1) and double SV taggers
…f RecoBTag/SoftLepton

- recovered softMuonTagInfos
…f RecoBTau/JetTagComputer

- added super-combined CSV + soft lepton (CSVSLV1) tagger
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_0_X.

70X additional b-taggers

It involves the following packages:

RecoBTag/SoftLepton
RecoBTau/JetTagComputer
RecoBTag/ImpactParameter
RecoBTag/SecondaryVertex

@thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@ktf
Copy link
Contributor

ktf commented Aug 28, 2013

@nclopezo can you please test this?

@thspeer
Copy link
Contributor

thspeer commented Aug 28, 2013

Working @thspeer

@nclopezo
Copy link
Contributor

Hi,

I ran the tests on top of CMSSW_7_0_X_2013-08-28-0200, all tests passed

The logs are here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/299/console

and the artifacts here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/299

@thspeer
Copy link
Contributor

thspeer commented Aug 29, 2013

Please change code to use "consumes" interface and getByToken instead of getByLabel

@ferencek
Copy link
Contributor Author

The RecoBTag subsystem is now fully migrated to the new consumes interface

@cmsbuild
Copy link
Contributor

Pull request #644 was updated. Signatures reset, please check and sign again.

@thspeer
Copy link
Contributor

thspeer commented Sep 2, 2013

+1
Signed f5fa39e in CMSSW_7_0_X_2013-08-28-0200-644
No change in reco, the additional taggers are not run in the default sequence

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

davidlt added a commit that referenced this pull request Sep 2, 2013
@davidlt davidlt merged commit 09109f9 into cms-sw:CMSSW_7_0_X Sep 2, 2013
@ferencek ferencek deleted the 70X-additionalBTaggers branch November 23, 2013 02:05
jpata pushed a commit to jpata/cmssw that referenced this pull request Jun 9, 2016
gkasieczka pushed a commit to gkasieczka/cmssw that referenced this pull request Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants