Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix valgrind warning in PFEGammaProducer #645

Merged
merged 4 commits into from Sep 3, 2013

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Aug 28, 2013

Based ontop of IB: CMSSW_7_0_X_2013-08-26-1400

@ktf
Copy link
Contributor

ktf commented Aug 28, 2013

@nclopezo can you please test?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_0_X.

Fix valgrind warning in PFEGammaProducer

It involves the following packages:

RecoParticleFlow/PFProducer

@thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@nclopezo
Copy link
Contributor

Hi,

I tested this pull request on top of CMSSW_7_0_X_2013-08-28-0200, all tests passed.

You can see the logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/301/console

And the artifacts are here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/301

@lgray
Copy link
Contributor Author

lgray commented Aug 29, 2013

@slava77
If you look at the log file:
/afs/cern.ch/user/l/lgray/work/public/CMSSW_7_0_X_2013-08-26-1400/src/RecoParticleFlow/Configuration/test/valgrind_pfeg.log

You'll see that the jump on uninitialized member is now gone, using this patch set.

@lgray
Copy link
Contributor Author

lgray commented Aug 31, 2013

@slava77 @thspeer The valgrind warning is no longer seen. Please merge this.

@lgray
Copy link
Contributor Author

lgray commented Sep 3, 2013

@slava77 @thspeer ping

@slava77
Copy link
Contributor

slava77 commented Sep 3, 2013

working @slava77

@slava77
Copy link
Contributor

slava77 commented Sep 3, 2013

+1

tested as CMSSW_7_0_X_2013-09-03-0200/sign248/pull645-mo
Signing as of c6fe9aa

The original report was based on fastsim mu pt10
runTheMatrix.py --command '-n 10 --prefix "time valgrind --tool=memcheck --suppressions=$CMSSW_RELEASE_BASE/src/Utilities/ReleaseScripts/data/cms-valgrind-memcheck.supp --num-callers=20 --xml=yes --xml-file=valgrind-%p.xml " ' -l 5.2 --useInput=all

valgrind errors are gone

no changes in outputs, as expected

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

nclopezo added a commit that referenced this pull request Sep 3, 2013
Fix valgrind warning in PFEGammaProducer
@nclopezo nclopezo merged commit 4acf9e6 into cms-sw:CMSSW_7_0_X Sep 3, 2013
gkasieczka pushed a commit to gkasieczka/cmssw that referenced this pull request Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants