New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow experiment type to be set in 7_2_X #6487
Allow experiment type to be set in 7_2_X #6487
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_2_X. Allow experiment type to be set in 7_2_X It involves the following packages: CalibCalorimetry/EcalLaserSorting @vciulli, @apfeiffer1, @diguida, @bendavid, @emeschi, @covarell, @thuer, @ktf, @cmsbuild, @ggovi, @Dr15Jones, @rcastello, @cerminar, @mommsen, @mmusich, @mulhearn, @nclopezo can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
Allow experiment type to be set in 7_2_X
Remi Mommsen discovered that there is no way to set the ExperimentType data member in ProducerSourceBase, which is the base class of FRDStreamSource.
This pull request fixes this problem in 7_2_X.
Remi requested the problem be fixed in 7_2_X and 7_3_X.
A separate pull request (#6416) was used for 7_3_X.
The member function setRunAndEventInfo() needed an additional argument.
All classes inheriting from ProducerSourceBase needed this addtional argument added.
At the moment, only FRDStreamSource actually sets the ExperimentType (done in this pull request).