Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow experiment type to be set in 7_2_X #6487

Merged
merged 1 commit into from Nov 24, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Nov 18, 2014

Remi Mommsen discovered that there is no way to set the ExperimentType data member in ProducerSourceBase, which is the base class of FRDStreamSource.
This pull request fixes this problem in 7_2_X.
Remi requested the problem be fixed in 7_2_X and 7_3_X.
A separate pull request (#6416) was used for 7_3_X.
The member function setRunAndEventInfo() needed an additional argument.
All classes inheriting from ProducerSourceBase needed this addtional argument added.
At the moment, only FRDStreamSource actually sets the ExperimentType (done in this pull request).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_2_X.

Allow experiment type to be set in 7_2_X

It involves the following packages:

CalibCalorimetry/EcalLaserSorting
CondCore/Utilities
EventFilter/Utilities
FWCore/Integration
FWCore/Modules
FWCore/Sources
GeneratorInterface/AlpgenInterface
GeneratorInterface/LHEInterface
GeneratorInterface/MCatNLOInterface
IOMC/Input
IORawData/HcalTBInputService
IORawData/SiPixelInputSources
L1Trigger/GlobalMuonTrigger

@vciulli, @apfeiffer1, @diguida, @bendavid, @emeschi, @covarell, @thuer, @ktf, @cmsbuild, @ggovi, @Dr15Jones, @rcastello, @cerminar, @mommsen, @mmusich, @mulhearn, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @wddgit, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mommsen
Copy link
Contributor

mommsen commented Nov 19, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants