Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important BUG FIX in parameter assignment of millepede-based tracker ali... #6516

Closed
wants to merge 1 commit into from
Closed

Important BUG FIX in parameter assignment of millepede-based tracker ali... #6516

wants to merge 1 commit into from

Conversation

mschrode
Copy link

...gnment

The bug corrupts the IOV-dependent alignment in releases compiled with
slc6_amd64_gcc472 and later. It is caused by using a dangling reference to
an edm::EventID object to determine the run number. At least with the gcc
versions in SLC6, this results in an incorrect determination of the current
IOV. Details are given in this presentation at the tracker-alignment meeting:

https://indico.cern.ch/event/342234/session/0/contribution/8/0/material/slides/0.pdf

The commit is a quick fix to ensure a working alingment fit. There might be
a more involved follow-up to avoid similar bugs in the future.

@uhh2-bot
Important BUG FIX in parameter assignment of millepede-based tracker …
5007182 
…alignment

The bug corrupts the IOV-dependent alignment in releases compiled with
slc6_amd64_gcc472 and later. It is caused by using a dangling reference to
an edm::EventID object to determine the run number. At least with the gcc
versions in SLC6, this results in an incorrect determination of the current
IOV. Details are given in this presentation at the tracker-alignment meeting:

https://indico.cern.ch/event/342234/session/0/contribution/8/0/material/slides/0.pdf

The commit is a quick fix to ensure a working alingment fit. There might be
a more involved follow-up to avoid similar bugs in the future.
@cmsbuild cmsbuild added this to the Next CMSSW_7_2_X milestone Nov 20, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mschrode (Matthias Schroeder) for CMSSW_7_2_X.

Important BUG FIX in parameter assignment of millepede-based tracker ali...

It involves the following packages:

Alignment/CommonAlignmentProducer

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @frmeier, @mmusich, @tlampen this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@frmeier
Copy link
Contributor

frmeier commented Nov 20, 2014

+1
This bugfix allows us to run on SLC6 without kludges. Would love to have a fast integration to make alignment procedures smoother. Endorsed in the tracker alignment meeting of today.
Frank, for the alignment conveners.

@cmsbuild
Copy link
Contributor

+1
Tested at: 5007182
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6516/1087/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6516/1087/summary.html

@mschrode mschrode mentioned this pull request Dec 1, 2014
Merged
@mschrode
Copy link
Author

mschrode commented Dec 1, 2014

superseded by #6726

@mschrode mschrode closed this Dec 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending comparison-available orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
Next CMSSW_7_2_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mschrode @cmsbuild @frmeier @uhh2-bot