Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Me0 global reco #6576

Closed
wants to merge 3 commits into from
Closed

Conversation

dnash86
Copy link
Contributor

@dnash86 dnash86 commented Nov 24, 2014

Full update of ME0 Global Reco. Includes a few updates to Validation/RecoMuon that enable the me0muon analyzer to use chi2 association. Also includes a fix to ensure successful re recoing of old root files that contain out-of-date me0muons (dropping them in exchange for the new me0muons).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dnash86 for CMSSW_6_2_X_SLHC.

Me0 global reco

It involves the following packages:

DataFormats/MuonReco
RecoMuon/MuonIdentification
SLHCUpgradeSimulations/Configuration
Validation/RecoMuon

@civanch, @nclopezo, @StoyanStoynev, @danduggan, @mdhildreth, @cmsbuild, @deguio, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @bellan, @trocino, @amagitte, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fratnikov
Copy link

@dnash86 Is this related with #6524 or it is stand alone PR?

@mark-grimes
Copy link

Superseded by #6585.

@dnash86
Copy link
Contributor Author

dnash86 commented Nov 25, 2014

@fratnikov This is unrelated to #6524
@mark-grimes Thanks for the new PR The FastSimulation/Configuration package was meant for use with the EmulatedSegments, so we hadn't used it in a while - I had forgotten to change it and for some reason did not get a compile error when testing this PR.

@cmsbuild
Copy link
Contributor

Pull request #6576 was updated. @civanch, @nclopezo, @StoyanStoynev, @danduggan, @mdhildreth, @cmsbuild, @deguio, @slava77 can you please check and sign again.

cmsbuild added a commit that referenced this pull request Nov 25, 2014
@cmsbuild
Copy link
Contributor

-1
Tested at: ddaedb6
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_6_2_X_SLHC_2014-11-24-1400/src/RecoMuon/TrackerSeedGenerator/src/TrackerSeedCleaner.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_6_2_X_SLHC_2014-11-24-1400/src/RecoMuon/TrackerSeedGenerator/src/TrackerSeedGeneratorFactory.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_6_2_X_SLHC_2014-11-24-1400/src/RecoMuon/TrackerSeedGenerator/src/TrackerSeedGenerator.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_6_2_X_SLHC_2014-11-24-1400/src/SLHCUpgradeSimulations/L1TrackTrigger/src/ClusteringAlgorithmRecord.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_6_2_X_SLHC_2014-11-24-1400/src/FastSimulation/Configuration/test/TestAnalyzer_Final.cc: In member function 'virtual void TestAnalyzer_Final::analyze(const edm::Event&, const edm::EventSetup&)':
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_6_2_X_SLHC_2014-11-24-1400/src/FastSimulation/Configuration/test/TestAnalyzer_Final.cc:205:57: error: conversion from 'ME0Segment' to non-scalar type 'EmulatedME0SegmentRef {aka edm::Refstd::vector}' requested
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_6_2_X_SLHC_2014-11-24-1400/src/SLHCUpgradeSimulations/L1TrackTrigger/src/ES_ClusteringAlgorithm.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_6_2_X_SLHC_2014-11-24-1400/src/SLHCUpgradeSimulations/L1TrackTrigger/src/ES_HitMatchingAlgorithm.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_6_2_X_SLHC_2014-11-24-1400/src/SLHCUpgradeSimulations/L1TrackTrigger/src/ES_TrackingAlgorithm.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_6_2_X_SLHC_2014-11-24-1400/src/SLHCUpgradeSimulations/L1TrackTrigger/src/HitMatchingAlgorithmRecord.cc 
gmake: **\* [tmp/slc6_amd64_gcc472/src/FastSimulation/Configuration/test/TestAnalyzer_Final/TestAnalyzer_Final.o] Error 1


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6576/1148/summary.html

@mark-grimes
Copy link

@dnash86 could you close this? Usually they close automatically if all commits have been merged in another pull request, but it sees the python config commit has different for some reason.

@nclopezo nclopezo closed this Nov 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants