Move bool operator>(l1t::Jet&, l1t::Jet&) to l1t namespace #6582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following line in `BitonicSort.h`
bool lComp( *lFirst > *lSecond );
depends on template argument type. Thus argument-dependent lookup (ADL)
is being used here to find `bool operator>(l1t::Jet&, l1t::Jet&)`.
ADL is done once all argument types are known, i.e., in template
instantiation location. It this case it happens in a few places from
`BitonicSort.h` and `Stage2Layer2JetAlgorithmFirmwareImp1.cc`.
They all require template specialization: `BitonicSort<l1t::Jet>`.
The operator is not found on the first look up (unqualified lookup),
because it's delcared after template delcaration. It's also not found in
second look up (ADL), because it's not in a class's namespace, but in a
global namespace.
The patch adds `bool operator>(l1t::Jet&, l1t::Jet&)` to `l1t` namespace
to allow ADL to find the operator.
Resolves error with Clang.
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_7_4_X. Move bool operator>(l1t::Jet&, l1t::Jet&) to l1t namespace It involves the following packages: L1Trigger/L1TCalorimeter @cmsbuild, @nclopezo, @mulhearn can you please review it and eventually sign? Thanks. |
|
+1 |
cmsbuild
added
comparison-pending
fully-signed
l1-approved
tests-approved
and removed
comparison-pending
l1-pending
pending-signatures
tests-approved
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged. |
cmsbuild
added a commit
that referenced
this pull request
Nov 25, 2014
Move bool operator>(l1t::Jet&, l1t::Jet&) to l1t namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following line in
BitonicSort.hdepends on template argument type. Thus argument-dependent lookup (ADL)
is being used here to find
bool operator>(l1t::Jet&, l1t::Jet&).ADL is done once all argument types are known, i.e., in template
instantiation location. It this case it happens in a few places from
BitonicSort.handStage2Layer2JetAlgorithmFirmwareImp1.cc.They all require template specialization:
BitonicSort<l1t::Jet>.The operator is not found on the first look up (unqualified lookup),
because it's delcared after template delcaration. It's also not found in
second look up (ADL), because it's not in a class's namespace, but in a
global namespace.
The patch adds
bool operator>(l1t::Jet&, l1t::Jet&)tol1tnamespaceto allow ADL to find the operator.
Resolves error with Clang.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch