Run L1T emulation for Fast Simulation bugfix 730 #6589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extra to sim or unpacked digis based on context
|
A new Pull Request was created by @mulhearn for CMSSW_7_4_X. Run L1T emulation for Fast Simulation bugfix 730 It involves the following packages: L1Trigger/L1TCommon @cmsbuild, @nclopezo, @mulhearn can you please review it and eventually sign? Thanks. |
|
By the way: this PR is for 74X, |
| @@ -15,23 +15,42 @@ def customiseSimL1EmulatorForPostLS1(process): | |||
| #print "INFO: loading RCT LUTs" | |||
| #process.load("L1Trigger.L1TCalorimeter.caloStage1RCTLuts_cff") | |||
|
|
|||
| #if hasattr(process,'simulationWithFamos'): | |||
There was a problem hiding this comment.
Please remove up to line 22 (remnant of #6584)
cmsbuild
added
comparison-available
and removed
comparison-pending
l1-pending
pending-signatures
tests-approved
labels
ktf
added a commit
that referenced
this pull request
Nov 27, 2014
…x-730 Run L1T emulation for Fast Simulation bugfix 730
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when running Fast Simulation in postLS1 scenario, where new L1T emulation was not run but inputs were expected downstream. This bug fix causes new L1T emulation to be run in all scenarios where legacy GCT emulation was run, if postLS1 customization is made. It also sets the l1extra producer to use simulated or unpacked digis based on context.