New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix track cluster remover template definition #6595
fix track cluster remover template definition #6595
Conversation
A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_3_X. fix track cluster remover template definition It involves the following packages: RecoLocalTracker/SubCollectionProducers @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
@mtosi : did you provide a 74X copy of this PR? |
Hi Andrea, if HLT proposes #6618 as a combined PR, maybe you could stick to a single one? |
@@ -1,18 +1,21 @@ | |||
### who is using this python file ? | |||
### I found it obsolete, at least in terms of the TrackClusterRemover setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
…fixTrackClusterRemover fix track cluster remover template definition
in the migration from HLTTrackClusterRemover to TrackClusterRemover
I realized that in confDB we do not have the TrackClusterRemover template :(
it turned out to be due to the fact that no cfi is available for this module
moreover, this module is used by explicitly defining it in all tracking cff files !
=> this PR is meant for
w/ default parameters which should be in as general as possible
in order to instead import-and-clone the default template
this PR is needed for then letting the HLT config being migrated to use TrackClusterRemover (which is multithread safe), instead of HLTTrackClusterRemover which should not be maintained anymore ...