Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable MiniAOD validation for Jet and MET, switch to new JetCorrector #6629

Merged
merged 3 commits into from Dec 10, 2014

Conversation

cmsbuild
Copy link
Contributor

We enabled running on MiniAOD both for the Validation/RecoMET and Validation/RecoJet package. We use now the new (thread-safe) JetCorrector implementation. We modified the parameter set for both the JetTester and MetTester modules. This time we paid attention to modify the RecoHI JetSequence accordingly.
Automatically ported from CMSSW_7_3_X #6519

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_7_4_X.

enable MiniAOD validation for Jet and MET, switch to new JetCorrector

It involves the following packages:

Configuration/StandardSequences
FastSimulation/Configuration
Validation/RecoHI
Validation/RecoJets
Validation/RecoMET

@civanch, @nclopezo, @lveldere, @danduggan, @mdhildreth, @cmsbuild, @franzoni, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmarionncern, @makortel, @kkrajczar, @rappoccio, @GiacomoSguazzoni, @TaiSakuma, @rovere, @VinInn, @appeltel, @ahinzmann, @richard-cms, @RylanC24, @nhanvtran, @schoef, @cerati, @mariadalfonso, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@nclopezo
Copy link
Contributor

+1
Latest commit marked as "Tests OK" in CMSSW_7_3_X

@lveldere
Copy link
Contributor

+1

@webermat
Copy link
Contributor

webermat commented Dec 4, 2014

For us the comparisons we had in #6519 showed the expected behavior.

@deguio
Copy link
Contributor

deguio commented Dec 4, 2014

+1
passes WF 11325 now.
F.

@deguio
Copy link
Contributor

deguio commented Dec 5, 2014

not sure why the orp signature is needed here.

davidlange6 added a commit that referenced this pull request Dec 10, 2014
enable MiniAOD validation for Jet and MET, switch to new JetCorrector
@davidlange6 davidlange6 merged commit e9f287a into cms-sw:CMSSW_7_4_X Dec 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants