Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide different error message for DAS lookup issues. #6641

Merged
merged 1 commit into from Nov 27, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Nov 26, 2014

Fix the longstanding bug where a das failure is indicated as an error in
step two. This introduces a new DAS_ERROR exit code which is correctly
associated to step1. This is still not enough to catch the cases in
which is the lookup for pileup which fails, but at least is a good
start.

Fix the longstanding bug where a das failure is indicated as an error in
step two. This introduces a new DAS_ERROR exit code which is correctly
associated to step1. This is still not enough to catch the cases in
which is the lookup for pileup which fails, but at least is a good
start.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_4_X.

Provide different error message for DAS lookup issues.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @srimanob, @nclopezo, @boudoul, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@ktf
Copy link
Contributor Author

ktf commented Nov 26, 2014

@nclopezo this probably requires cleanups also in the way we process logs. In particular we should have a different color (puke green?) for DAS errors.

@ktf
Copy link
Contributor Author

ktf commented Nov 27, 2014

shocking pink is good as well..

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@nclopezo
Copy link
Contributor

I added the label for the "DAS_ERROR" in this pull request: cms-sw/cms-sw.github.io#11

@ktf
Copy link
Contributor Author

ktf commented Nov 27, 2014

Discussing privately with @franzoni we agreed this is a nice thing to have (Gio' correct me if I'm wrong). Bypassing pdmv signature.

ktf added a commit that referenced this pull request Nov 27, 2014
Provide different error message for DAS lookup issues.
@ktf ktf merged commit b9db7ba into cms-sw:CMSSW_7_4_X Nov 27, 2014
@ktf ktf deleted the proper-das-error branch November 27, 2014 15:08
@franzoni
Copy link

haven't had the time to look at it - but yes, the described functionality is good to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants