New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide different error message for DAS lookup issues. #6641
Conversation
Fix the longstanding bug where a das failure is indicated as an error in step two. This introduces a new DAS_ERROR exit code which is correctly associated to step1. This is still not enough to catch the cases in which is the lookup for pileup which fails, but at least is a good start.
A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_4_X. Provide different error message for DAS lookup issues. It involves the following packages: Configuration/PyReleaseValidation @cmsbuild, @srimanob, @nclopezo, @boudoul, @franzoni can you please review it and eventually sign? Thanks. |
@nclopezo this probably requires cleanups also in the way we process logs. In particular we should have a different color (puke green?) for DAS errors. |
shocking pink is good as well.. |
I added the label for the "DAS_ERROR" in this pull request: cms-sw/cms-sw.github.io#11 |
Discussing privately with @franzoni we agreed this is a nice thing to have (Gio' correct me if I'm wrong). Bypassing pdmv signature. |
Provide different error message for DAS lookup issues.
haven't had the time to look at it - but yes, the described functionality is good to have. |
Fix the longstanding bug where a das failure is indicated as an error in
step two. This introduces a new DAS_ERROR exit code which is correctly
associated to step1. This is still not enough to catch the cases in
which is the lookup for pileup which fails, but at least is a good
start.