Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Run2 simulation GT for HCal. #6642

Merged
merged 2 commits into from Dec 9, 2014
Merged

Conversation

diguida
Copy link
Contributor

@diguida diguida commented Nov 26, 2014

New Global Tags for Run2 simulations (ideal, startup, asymptotic) with the following change:

  • updating HCal response corrections restoring the energy scale in HB and HE after introduction of TimeSlew simulation (DIGI) + Method 2 (RECO).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_3_X.

New Run2 simulation GT for HCal.

It involves the following packages:

Configuration/AlCa

@diguida, @cerminar, @cmsbuild, @nclopezo, @rcastello, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Nov 26, 2014

Why only run2?
We have the same HCAL reco in all eras (run1 and run2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

@diguida
Copy link
Contributor Author

diguida commented Dec 9, 2014

@davidlange6
I assume you are referring to Run2 MC (given that the Run1 MC BeamSpot is untouched since at least one year). As you can see here e.g. for Run2 asymptotic scenario, we are still using the old BeamSpot, i.e. as checked for CSA14.
The new BeamSpot was supposed to come only in 74X (and actually it was reverted).

@davidlange6
Copy link
Contributor

ah - indeed, I'm confusing 73 and 74.. Great.

On Dec 9, 2014, at 4:24 PM, Salvatore Di Guida notifications@github.com
wrote:

@davidlange6
I assume you are referring to Run2 MC (given that the Run1 MC BeamSpot is untouched since at least one year). As you can see here e.g. for Run2 asymptotic scenario, we are still using the old BeamSpot, i.e. as determined for CSA14.
The new BeamSpot was supposed to come only in 74X (and actually it was reverted).


Reply to this email directly or view it on GitHub.

@diguida
Copy link
Contributor Author

diguida commented Dec 9, 2014

@davidlange6 @slava77 @abdoulline
I assume that you want this change for Run1 MC to be forward-ported to 74X too...

@davidlange6
Copy link
Contributor

Yes - definitely.

On Dec 9, 2014, at 4:27 PM, Salvatore Di Guida notifications@github.com
wrote:

@davidlange6 @slava77 @abdoulline
I assume that you want this change for Run1 MC to be forward-ported to 74X too...


Reply to this email directly or view it on GitHub.

@diguida
Copy link
Contributor Author

diguida commented Dec 9, 2014

Ok, preparing a PR also there, stay tuned.

@diguida
Copy link
Contributor Author

diguida commented Dec 9, 2014

74X forward port in #6846

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants