fix occasional crash in PulseShapeFitOOTPileupCorrection for zero processed events in a job (as in #6646 )

[slava77]

Initialized data members

the crash in e.g. 106.0 is gone.

The crash in the original code can be more reliably reproduced with the malloc magic

export MALLOC_CHECK_=3 
export MALLOC_PERTURB_=$(($RANDOM % 255 + 1))
cmsRunGlibC config.py

[slava77]

+1

for #6647 cce5d3a
same as #6646

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[cmsbuild]

+1
Tested at: cce5d3a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6647/1188/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6647/1188/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_3_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar

[davidlt]

Good to see that the magic works! Have you tried to look how much RECO is affected by random memory? That is, running with different MALLOC_PERTURB_ each time and comparing the results.

[davidlange6]

+1

[slava77]

That's on my to-do list

On 11/27/14, 4:24 AM, davidlt wrote:

Good to see that the magic works! Have you tried to look how much RECO
is affected by random memory? That is, running with different
|MALLOC_PERTURB_| each time and comparing the results.

—
Reply to this email directly or view it on GitHub
#6647 (comment).

---

Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)

---