Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent with root6 interface change #6648

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Nov 26, 2014

This critical fix must be picked up concurrently with advancing ROOT6 to the head of the v6-02-00 patches branch.
This pull request does three things:

  1. Adapts to a new interface in ROOT6 from Philippe Canal. This reduces the number of CondCore unit tests that fail from 20 to 11.
  2. Two unit tests that are fixed by this change have an assert removed. This assert previously aborted the tests to avoid an infinite loop that otherwise occurred.
  3. One unit test (testORAIO) has an assert added to fail the test immediately. The new ROOT interface fixed the previous failure of this test, but this test now hoards memory to toe point of exhaustion. So, we fail deliberately to avoid this for now.
    Please merge this request in the same IB as ROOT6 is updated to the HEAD of the v6-02-00-patches branch, as they are mutually dependent.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_3_ROOT6_X.

Concurrent with root6 interface change

It involves the following packages:

CondCore/DBCommon
CondCore/ORA

@apfeiffer1, @nclopezo, @cerminar, @cmsbuild, @diguida, @rcastello, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

davidlt added a commit that referenced this pull request Nov 27, 2014
@davidlt davidlt merged commit 767078b into cms-sw:CMSSW_7_3_ROOT6_X Nov 27, 2014
@davidlt
Copy link
Contributor

davidlt commented Nov 27, 2014

cms-sw/cmsdist#1217

@wmtan wmtan deleted the ConcurrentWithROOT6InterfaceChange branch November 27, 2014 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants