migration from EDFilter to stream::EDFilter (JetVertexChecker)

[mtosi]

as reported by @fwyzard
https://docs.google.com/spreadsheets/d/1D9khDvOl05WEbznsUPCusEbrHeep9hh8cXedMXX09Gc/edit#gid=0
there are modules used @HLT which still need to be migrated and be multithread safe

this is the migration of the module JetVertexChecker

[mtosi]

@cerati @VinInn @rovere

[cmsbuild]

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_7_4_X.

migration from EDFilter to stream::EDFilter (JetVertexChecker)

It involves the following packages:

RecoPixelVertexing/PixelVertexFinding

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @appeltel, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[Dr15Jones]

If the value can change the physics results it must be tracked.

[cmsbuild]

+1
Tested at: ea393aa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6670/1220/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6670/1220/summary.html

[slava77]

-1

please make the new parameters tracked (add them with default values in fillDescriptions)

[cmsbuild]

Pull request #6670 was updated. @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please check and sign again.

[mtosi]

"bot: there is a commit here" ?
sorry, I do not understand

[slava77]

if you make a commit to an old PR, the cms-bot often doesn't notice it.
So, some random text should be posted on the thread to trigger cms-bot
to notice updates.
we still don't have an automated solution to this

On 11/28/14, 12:56 PM, mia tosi wrote:

"bot: there is a commit here" ?
sorry, I do not understand

—
Reply to this email directly or view it on GitHub
#6670 (comment).

---

Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)

---

[mtosi]

ah, ok
thanks for the clarification

mia

On Nov 28, 2014, at 8:01 PM, Slava Krutelyov notifications@github.com wrote:

if you make a commit to an old PR, the cms-bot often doesn't notice it.
So, some random text should be posted on the thread to trigger cms-bot
to notice updates.
we still don't have an automated solution to this

On 11/28/14, 12:56 PM, mia tosi wrote:

"bot: there is a commit here" ?
sorry, I do not understand

—
Reply to this email directly or view it on GitHub
#6670 (comment).

---

Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: slava77@gmail.com
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)

---

—
Reply to this email directly or view it on GitHub.

[slava77]

+1

for #6670 7fa0d45

tested in CMSSW_7_4_X_2014-11-27-0200 ( test area sign469, in combination with PRs 6658-6659-6662-6670-6671-6687)

checked with a short matrix: no diffs in reco, no diffs in 5.1 and 25.0 short matrix DQM outputs

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

[cmsbuild]

+1
Tested at: 7fa0d45
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6670/1312/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request will be automatically merged.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6670/1312/summary.html