Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup unused arguments. #6733

Merged
merged 1 commit into from Dec 2, 2014
Merged

Cleanup unused arguments. #6733

merged 1 commit into from Dec 2, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Dec 2, 2014

Spotted in ICC builds.

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Dec 2, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2014

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_4_X.

Cleanup unused arguments.

It involves the following packages:

DataFormats/Common
FWCore/Framework

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@ktf
Copy link
Contributor Author

ktf commented Dec 2, 2014

Since these will basically rebuild everything even if they are trivial I'd vote for including them in the IB without tests. @Dr15Jones do you agree?

@Dr15Jones
Copy link
Contributor

+1
Early inclusion is fine with me.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes or unless it breaks tests.

ktf added a commit that referenced this pull request Dec 2, 2014
@ktf
Merge pull request #6733 from ktf/cleanup-unused
0cacb20 
Cleanup unused arguments.
@ktf ktf merged commit 0cacb20 into cms-sw:CMSSW_7_4_X Dec 2, 2014
@ktf ktf deleted the cleanup-unused branch December 2, 2014 14:09
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2014

+1
Tested at: e3829eb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6733/1363/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending core-approved fully-signed tests-pending
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ktf @cmsbuild @Dr15Jones